Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Get rid of exec_tools. #13401

Closed
wants to merge 1 commit into from

Conversation

benjaminp
Copy link
Contributor

Bazel has removed this attribute in bazelbuild/bazel@c061e57.

Bazel has removed this attribute in bazelbuild/bazel@c061e57.
@benjaminp benjaminp requested a review from a team as a code owner July 27, 2023 22:15
@benjaminp benjaminp requested review from perezd and removed request for a team July 27, 2023 22:15
@perezd perezd requested review from mkruskal-google and removed request for perezd July 27, 2023 22:16
@perezd
Copy link
Contributor

perezd commented Jul 27, 2023

@mkruskal-google can you triage if/when this is safe to accept given our Bazel support requirements?

@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 27, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 27, 2023
@mkruskal-google
Copy link
Member

If this passes tests today it should be safe

copybara-service bot pushed a commit that referenced this pull request Jul 28, 2023
Bazel has removed this attribute in bazelbuild/bazel@c061e57.

Closes #13401

COPYBARA_INTEGRATE_REVIEW=#13401 from benjaminp:exec_tools 9e718ff
FUTURE_COPYBARA_INTEGRATE_REVIEW=#13401 from benjaminp:exec_tools 9e718ff
PiperOrigin-RevId: 551884484
mkruskal-google pushed a commit to mkruskal-google/protobuf that referenced this pull request Jul 31, 2023
Bazel has removed this attribute in bazelbuild/bazel@c061e57.

Closes protocolbuffers#13401

COPYBARA_INTEGRATE_REVIEW=protocolbuffers#13401 from benjaminp:exec_tools 9e718ff
PiperOrigin-RevId: 552482730
@benjaminp benjaminp deleted the exec_tools branch August 6, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants