Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for components when using find_package #1609

Closed

Conversation

yeswalrus
Copy link

@yeswalrus yeswalrus commented May 26, 2016

Allow users to specify which parts of the library they want to import when issuing a find_package command.

Components are libprotobuf, libprotobuf-lite, libprotoc, and protoc. If no component is specified, all are assumed..

Fixes #1585 by allowing separate find_pacakage commands to be used for the libraries & protoc.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@yeswalrus yeswalrus force-pushed the cmake-separate-components branch 2 times, most recently from ffcb27d to a3cbd1a Compare May 27, 2016 01:06
@googlebot
Copy link

CLAs look good, thanks!

@yeswalrus yeswalrus changed the title Add Support for components when using find_package Add support for components when using find_package May 27, 2016
@yeswalrus yeswalrus force-pushed the cmake-separate-components branch 2 times, most recently from 77a1539 to 75a26b9 Compare June 1, 2016 00:06
@yeswalrus
Copy link
Author

#1654 Does a better job of solving this problem without the added complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants