Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed forward declaration of MemBlock class #4828

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

mmatuszak-google
Copy link
Contributor

Removed forward declaration of MemBlock class.

Declaration is in conflict with declaration ::strings::MemBlock

Removed forward declaration of MemBlock class.

Declaration is in conflict with declaration `::strings::MemBlock`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@acozzette acozzette self-assigned this Jun 25, 2018
@acozzette
Copy link
Member

@mmatuszak-google Could you try saying "I signed it!" and see if that makes the CLA bot happy?

@mmatuszak-google
Copy link
Contributor Author

mmatuszak-google commented Jun 26, 2018 via email

@mmatuszak-google
Copy link
Contributor Author

mmatuszak-google commented Jun 26, 2018 via email

@acozzette
Copy link
Member

I'm not sure why the CLA bot's unhappy, but I'll merge this anyway since I know you work for Google. Thanks for the pull request!

@acozzette acozzette merged commit ed00fbb into protocolbuffers:master Jun 27, 2018
@mmatuszak-google
Copy link
Contributor Author

mmatuszak-google commented Jun 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants