-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed forward declaration of MemBlock class #4828
Conversation
Removed forward declaration of MemBlock class. Declaration is in conflict with declaration `::strings::MemBlock`
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
@mmatuszak-google Could you try saying "I signed it!" and see if that makes the CLA bot happy? |
"I signed it!"
…On Mon, Jun 25, 2018 at 5:00 PM Adam Cozzette ***@***.***> wrote:
@mmatuszak-google <https://github.com/mmatuszak-google> Could you try
saying "I signed it!" and see if that makes the CLA bot happy?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4828 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARoc4VafC9YDCfUn5WgHQpIPGDYXm1J4ks5uAXmLgaJpZM4U3BPV>
.
|
I signed it!
…On Mon, Jun 25, 2018 at 4:44 PM googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google.com/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4828 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARoc4dD1QccKHwNazL9syh7VnXdFKavyks5uAXXQgaJpZM4U3BPV>
.
|
I'm not sure why the CLA bot's unhappy, but I'll merge this anyway since I know you work for Google. Thanks for the pull request! |
Thanks for helping me with this!
…On Tue, Jun 26, 2018 at 5:09 PM Adam Cozzette ***@***.***> wrote:
Merged #4828 <#4828>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4828 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARoc4U35pJQ-ll8n-ePhjbUU6pIGTjLgks5uAs1KgaJpZM4U3BPV>
.
|
Removed forward declaration of MemBlock class.
Declaration is in conflict with declaration
::strings::MemBlock