Add Javascript convenience getters/setters.

[twavv]

This is kind of a proof of concept.

I'm happy to add requisite tests and whatnot though I confess I'm not really sure (as of right now) how/where I would do that. It works for me™. Suggestions/guidance appreciated.

Would fix protocolbuffers/protobuf-javascript#93.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[twavv]

Je l'ai signé!

[googlebot]

CLAs look good, thanks!

[twavv]

Just for motivation, this would enable ES2015-idiomatic use of protobuf and reduce a lot of boilerplate code.

function registerUser(user: UserMessage) {
  const {email, password, name} = user;
  db.insert("users", {email, password, name, createdAt: Date.now()});
}

Might also be a way to address protocolbuffers/protobuf-javascript#81 without breaking backwards compatability (by having the getters return default values) but I'm not sure if that's something we want to do.

EDIT: Actually I don't think this should be used to address protocolbuffers/protobuf-javascript#81 (rather have an option on the CLI/in the GeneratorOptions struct).

[BSBandme]

@TeBoring Is this one of what we need for being compatible with react?

And do we need IE8 supported?

[TeBoring]

Thanks @travigd. This is really useful. I'll do some experiment internally. See whether it works.

[alexciesielski-pioner]

This looks great, looking forward to getting this merged.

[shaxbee]

This would resolve the problem that was root cause for creating #5397 as well would enable to simplify typings in grpc-web significantly.

[TeBoring]

The new code has some issue with our internal toolchain. Still working on that.

[aldobrynin]

Any update on this, guys?

[twavv]

Hi, @TeBoring, any updates? Anything you need me to do? We could also put this behind some kind of feature/CLI flag if we're worried about incompatibilities, yeah?

[twavv]

Bump! It's been over a year since this has been opened...

[jackielii]

In the mean time, we used code generation to generate client code which works quite well.

…

On Sat, 1 Feb 2020, 15:58 Travis DePrato, ***@***.***> wrote: Bump! It's been over a year since this has been opened... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5449?email_source=notifications&email_token=AACYEF5VR2C2BMVYRNQRD3DRAWLZHA5CNFSM4GJWXJ62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRAIBA#issuecomment-581043204>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACYEF4IZBERSWGQUB42HJLRAWLZHANCNFSM4GJWXJ6Q> .

[Srinjoy-Santra]

Can someone please help me with this issue? I think the question in the link is somewhat related to this.
https://stackoverflow.com/questions/60430081/how-to-convert-json-to-proto-message-format-in-javascript-client-side

[jmzwcn]

@TeBoring,

Could you please let us know what happen to this PR?

[ssilve1989]

bump?

[jmzwcn]

any progress?

[twavv]

If someone else wants to spearhead this, feel free.

[jmzwcn]

Let it is open? at least still have a hope to merge.