Add Bazel target for the Objective-C protobuf runtime #554
Conversation
| "objectivec/*.m", | ||
| # Timestamp.pbobjc.m and Duration.pbobjc.m are #imported by | ||
| # GPBWellKnownTypes.m. So we can't compile them separately | ||
| # (duplicate symbols). |
There was a problem hiding this comment.
Why not use the globs like on hdrs and filter out these two?
There was a problem hiding this comment.
Actually, listing just the umbrella header and the umbrella implementation works alright, because Bazel doesn't move the sources around like Cocoapods.
|
I realized I could simplify the Podspec file in the same way. |
|
(The Travis failure, Maven failing to download an artifact over the network, is unrelated to these changes - looks like a flake, but I don't have authority to rerun the test). |
|
Ping |
|
Could you squash commits into one? |
|
One for the BUILD file and one for the Podspec, or one commit for both? |
|
I prefer one for both. |
| # left out, as it's an umbrella implementation file. | ||
| s.exclude_files = 'objectivec/GPBProtocolBuffers.m' | ||
| s.source_files = 'objectivec/*.h', | ||
| 'objectivec/google/protobuf/*.pbobjc.h', |
There was a problem hiding this comment.
Can't these headers be covered by the umbrella header?
There was a problem hiding this comment.
@thomasvl says yes, so done.
Also add WKT headers to the umbrella file, and simplify Podspec with it. Plus some layout improvements to the BUILD file.
jcanizales
force-pushed
the
proto-objc-bazel
branch
from
4a48831
to
d5d7bb3
Compare
|
Squashed. |
|
LGTM |
Add Bazel target for the Objective-C protobuf runtime
…s#554) Fix a bug which caused us to generate a blank import comment when go_package contains just a package name (no import path): package foo // import "" Fixes protocolbuffers#553
PiperOrigin-RevId: 435158445
Also add WKT headers to the umbrella file, and simplify Podspec with it.
Plus some layout improvements to the BUILD file.
This is a dependency of the Bazel target for the ObjC gRPC runtime.
Part of grpc/grpc#2120