Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podspec for C++ #6404

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@rmstar
Copy link
Contributor

commented Jul 18, 2019

No description provided.

@googlebot googlebot added the cla: yes label Jul 18, 2019

@muxi

This comment has been minimized.

Copy link

commented Jul 18, 2019

@thomasvl - PTAL

Protobuf-cc.podspec Outdated Show resolved Hide resolved
Protobuf-cc.podspec Outdated Show resolved Hide resolved
Protobuf-cc.podspec Outdated Show resolved Hide resolved
php/ext/google/protobuf/package.xml Outdated Show resolved Hide resolved
@thomasvl

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

@muxi - The protobuf team will also have to agree to maintain/updating this like they do the objc one with releases.

Protobuf-cc.podspec Outdated Show resolved Hide resolved
@muxi

This comment has been minimized.

Copy link

commented Jul 18, 2019

Sounds good. We will ask them about it. Thanks!

@thomasvl

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@muxi this seems fine to me, so you'll need to get someone on the protobuf team for final sign off on name (i.e. - Protobuf-cc or something else) and also that why want to maintain/publish this with releases.

@muxi

This comment has been minimized.

Copy link

commented Jul 19, 2019

@thomasvl - we will get this done. Thank you for the help again Thomas.

@rmstar rmstar force-pushed the rmstar:protobuf-cc branch from 5718850 to 668f5cf Jul 19, 2019

@@ -250,6 +250,11 @@ def UpdateObjectiveC():
r"^ s.version = '.*'$",
" s.version = '%s'" % GetFullVersion(rc_suffix = '-rc'),
line))
RewriteTextFile('Protobuf-cc.podspec',

This comment has been minimized.

Copy link
@TeBoring

TeBoring Jul 23, 2019

Contributor

cc to c++

This comment has been minimized.

Copy link
@rmstar

rmstar Jul 23, 2019

Author Contributor

Thanks for catching that. Fixed.

@rmstar rmstar force-pushed the rmstar:protobuf-cc branch from c4e798d to 63248e6 Jul 23, 2019

@TeBoring TeBoring self-assigned this Jul 23, 2019

@TeBoring TeBoring added the kokoro:run label Jul 23, 2019

@TeBoring TeBoring merged commit 2c76c2c into protocolbuffers:master Jul 23, 2019

55 checks passed

Bazel Kokoro build successful
Details
Dist artifact installation Kokoro build successful
Details
Linux 32-bit Kokoro build successful
Details
Linux C# Kokoro build successful
Details
Linux C++ Distcheck Kokoro build successful
Details
Linux C++ TC Malloc Kokoro build successful
Details
Linux Golang Kokoro build successful
Details
Linux Java Compatibility Kokoro build successful
Details
Linux Java JDK 7 Kokoro build successful
Details
Linux Java Linkage Monitor Kokoro build successful
Details
Linux Java Oracle 7 Kokoro build successful
Details
Linux JavaScript Kokoro build successful
Details
Linux PHP Kokoro build successful
Details
Linux Python Kokoro build successful
Details
Linux Python 2.7 Kokoro build successful
Details
Linux Python 2.7 C++ Kokoro build successful
Details
Linux Python 3.3 Kokoro build successful
Details
Linux Python 3.3 C++ Kokoro build successful
Details
Linux Python 3.4 Kokoro build successful
Details
Linux Python 3.4 C++ Kokoro build successful
Details
Linux Python 3.5 Kokoro build successful
Details
Linux Python 3.5 C++ Kokoro build successful
Details
Linux Python 3.6 Kokoro build successful
Details
Linux Python 3.6 C++ Kokoro build successful
Details
Linux Python 3.7 Kokoro build successful
Details
Linux Python 3.7 C++ Kokoro build successful
Details
Linux Python C++ Kokoro build successful
Details
Linux Python Compatibility Kokoro build successful
Details
Linux Python Release Kokoro build successful
Details
Linux Ruby 2.3 Kokoro build successful
Details
Linux Ruby 2.4 Kokoro build successful
Details
Linux Ruby 2.5 Kokoro build successful
Details
Linux Ruby 2.6 Kokoro build successful
Details
Linux Ruby Release Kokoro build successful
Details
MacOS C++ Kokoro build successful
Details
MacOS C++ Distcheck Kokoro build successful
Details
MacOS JavaScript Kokoro build successful
Details
MacOS Obj-C CocoaPods Integration Kokoro build successful
Details
MacOS Obj-C OS X Kokoro build successful
Details
MacOS Obj-C iOS Debug Kokoro build successful
Details
MacOS Obj-C iOS Release Kokoro build successful
Details
MacOS PHP5.6 Kokoro build successful
Details
MacOS PHP7.0 Kokoro build successful
Details
MacOS Python Kokoro build successful
Details
MacOS Python C++ Kokoro build successful
Details
MacOS Python Release Kokoro build successful
Details
MacOS Ruby 2.3 Kokoro build successful
Details
MacOS Ruby 2.4 Kokoro build successful
Details
MacOS Ruby 2.5 Kokoro build successful
Details
MacOS Ruby 2.6 Kokoro build successful
Details
MacOS Ruby Release Kokoro build successful
Details
Mergeable Mergeable Run has been Completed!
Details
Windows C# Kokoro build successful
Details
Windows Csharp Release Kokoro build successful
Details
Windows Python Release Kokoro build successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.