Fix issues for php map when parsing missing key/value #6588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For missing message value, map should create a default message instance in order to keep its invariable. * On 32-bit platform, int64 map key should be string
stanley-cheung
approved these changes
Aug 29, 2019
| // For MapEntry, getValue should always return a valid value. Thus, we | ||
| // need to create a default instance value if the value type is | ||
| // message, in case no value is provided in data. | ||
| $value_field = $desc->getFieldByNumber(2); |
There was a problem hiding this comment.
why the number 2 here specifically?
There was a problem hiding this comment.
Map entry only has key (1) and value (2) field.
Besides, only value field can be message type.
|
Integration test implemented in #6560, which will catch bugs fixed in this issue. |
|
Thanks LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instance in order to keep its invariable.
Integration test implemented in #6560, which will catch bugs fixed in this issue.