Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Multiple Request for PHP #7008

Merged
merged 8 commits into from
Dec 12, 2019
Merged

Fix Multiple Request for PHP #7008

merged 8 commits into from
Dec 12, 2019

Conversation

TeBoring
Copy link
Contributor

Fixes #7006

@TeBoring
Class entry is obsolete in the second request
3a7e06c 
1) Needes to use class name in persistent map
2) Invalidate class entry stored in descriptor
@TeBoring
Add new files to dist
ef580a9
@TeBoring TeBoring mentioned this pull request Dec 11, 2019
Closed
@TeBoring TeBoring changed the title Fix Multiple Request for PHP [WIP] Fix Multiple Request for PHP Dec 12, 2019
stanley-cheung
stanley-cheung approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TeBoring TeBoring merged commit fe1790c into protocolbuffers:3.11.x Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
cla: yes php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TeBoring @stanley-cheung @googlebot @protobuf-kokoro