Update param type for PHP Internal Mapfield::offsetGet #8033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor doctype change for the PHP codebase, Internal\Mapfield::offsetGet method
The param was typed as
object
which is invalid as when items are set in the container the key passes throughcheckKey
where it enforces the key must be various classes of integer, bool or string. Thus I have replaced it with a union type (in future this can be a proper PHP level typehint, but for now only doctype)I encountered this whilst using a client that consumes protocol buffers, and found that my IDE was telling me that
$item->offsetGet('key')
was invalid, yet on running the code I got the expected output from the Map container.