Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update param type for PHP Internal Mapfield::offsetGet #8033

Merged
merged 1 commit into from Nov 30, 2020
Merged

Update param type for PHP Internal Mapfield::offsetGet #8033

merged 1 commit into from Nov 30, 2020

Commits on Nov 12, 2020

  1. Update param type on offsetGet 

    The param was typed as `object` which is invalid as when items are set in the container the key passes through `checkKey` where it enforces the key must be various classes of integer, bool or string. Thus I have replaced it with a union type (in future this can be a proper PHP level typehint, but for now only doctype)
    @M1ke
    M1ke committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    5e999d8 View commit details
    Browse the repository at this point in the history