feat: [PHP] remove legacy generate class file #9621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the point of leaving the alias if the old classes have been removed? |
|
@haberman my thought was that, since not generating a file doesn't remove the files someone would already have, this wouldn't be destructive. However, removing the Therefore, it seemed like a better idea to do this in phases. Remove the legacy file generation, then remove the |
haberman
approved these changes
May 10, 2022
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…iases feat: [PHP] remove legacy generate class file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9593
Remove the generation of the legacy class files for nested messages. Leave the call to
class_aliasat the bottom of namespaced nested message classes alone for now.