Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the JavaScript implementation #9874

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Remove the JavaScript implementation #9874

merged 1 commit into from
Apr 28, 2022
+10 −61,158

Conversation

acozzette
Copy link
Member

This implementation is about to be split out into a separate Git repo.

@acozzette acozzette marked this pull request as draft April 27, 2022 20:39
@acozzette
Remove the JavaScript implementation
3b673d9 
This implementation is about to be split out into a separate Git repo.
@acozzette acozzette marked this pull request as ready for review April 27, 2022 23:19
@acozzette acozzette requested a review from haberman April 27, 2022 23:20
@acozzette acozzette merged commit 860f8ad into protocolbuffers:main Apr 28, 2022
@acozzette acozzette deleted the javascript branch April 28, 2022 19:08
@sampajano sampajano mentioned this pull request May 13, 2022
Closed
samhowes added a commit to samhowes/protobuf-javascript that referenced this pull request May 27, 2022
@samhowes
Update package.json pointer to the new repository
08f34ba 
Improve documentation of javascript npm package now that we're in a new repository
grpc/grpc-web#1241 
protocolbuffers/protobuf#9874
@samhowes samhowes mentioned this pull request May 27, 2022
Merged
@ccakes ccakes mentioned this pull request Jun 18, 2022
Closed
@szigetics szigetics mentioned this pull request Jun 28, 2022
Open
@zepatrik
Copy link

I assume the new repo is https://github.com/protocolbuffers/protobuf-javascript? Or where did this go? How can I use it now?

@zepatrik
Copy link

Hm ok after two hours of research it seems this was just removed and after 3.20.1 there is no way to generate js. How is this not a breaking change??

@mayankav
Copy link

mayankav commented Jul 11, 2022 •
edited
Loading

@acozzette why was it removed from this repo?

@nocive

This comment was marked as abuse.

Sign in to view
@srabraham srabraham mentioned this pull request Aug 11, 2022
Closed
@alexeagle
Copy link
Collaborator

@zepatrik yes, https://github.com/protocolbuffers/protobuf-javascript is the new repo.

@szigetics
Copy link

szigetics commented Sep 29, 2022 •
edited
Loading

A possible solution for the missing Javascript generator can be found here : protocolbuffers/protobuf-javascript#127 (comment)

@pietrodn
Copy link

There is an official first-party solution: if you npm install grpc-tools, then you simply use grpc_tools_node_protoc (which is inside node_modules/.bin) instead of protoc. See documentation.

This way I managed to do without protoc-gen-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haberman haberman haberman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@acozzette @zepatrik @mayankav @nocive @alexeagle @szigetics @pietrodn @haberman @protobuf-kokoro