Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added metamask check if user is connected for reality link #1188

Merged
merged 4 commits into from
Oct 20, 2020
Merged

added metamask check if user is connected for reality link #1188

merged 4 commits into from
Oct 20, 2020

Conversation

Mi-Lan
Copy link
Contributor

@Mi-Lan Mi-Lan commented Oct 19, 2020

No description provided.

@Mi-Lan Mi-Lan linked an issue Oct 19, 2020 that may be closed by this pull request
Reality.eth link fails if metamask enabled but not connected #1081
Closed
@Mi-Lan Mi-Lan added the bug Something isn't working label Oct 19, 2020
@Mi-Lan Mi-Lan self-assigned this Oct 19, 2020
kadenzipfel
kadenzipfel suggested changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@kadenzipfel kadenzipfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but there are other places where we set the reality link which need to be updated. Bonus points if you can consolidate the reality link generating process to single place and display the generated link in each corresponding location.

app/src/components/market/common/additional_market_data/index.tsx Outdated Show resolved Hide resolved
@Mi-Lan
Copy link
Contributor Author

Mi-Lan commented Oct 20, 2020 •
edited
Loading

This is good, but there are other places where we set the reality link which need to be updated. Bonus points if you can consolidate the reality link generating process to single place and display the generated link in each corresponding location.

Yeah that makes sense! I made new commit as you can see i made custom hook that encapsulates that logic and i just imported it everywhere i saw that reality link was used...I thought about passing useRealityLink state from open component to additional market data component via props but i think that will makes code more unreadable....what do you think?

kadenzipfel
kadenzipfel approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@kadenzipfel kadenzipfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👏

@kadenzipfel kadenzipfel merged commit 47303eb into master Oct 20, 2020
@kadenzipfel kadenzipfel deleted the feature/#1081 branch October 20, 2020 17:41
@pimato pimato added this to the Version 1.1.9 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadenzipfel kadenzipfel kadenzipfel approved these changes

Assignees

@Mi-Lan Mi-Lan

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.1.9
Development

Successfully merging this pull request may close these issues.

Reality.eth link fails if metamask enabled but not connected
3 participants
@Mi-Lan @kadenzipfel @pimato