Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1194 #1314

Merged
merged 96 commits into from
Mar 1, 2021
Merged

Feature/#1194 #1314

merged 96 commits into from
Mar 1, 2021

Conversation

Mi-Lan
Copy link
Contributor

@Mi-Lan Mi-Lan commented Nov 5, 2020

issue #1194

@Mi-Lan Mi-Lan self-assigned this Nov 5, 2020
@Mi-Lan Mi-Lan marked this pull request as draft November 5, 2020 16:22
@Mi-Lan Mi-Lan linked an issue Nov 5, 2020 that may be closed by this pull request
@pimato
Copy link
Contributor

pimato commented Nov 6, 2020

@Mi-Lan you should be able to show the data now at least on Rinkeby: https://thegraph.com/explorer/subgraph/protofire/omen-rinkeby

@Mi-Lan Mi-Lan added the UI label Nov 10, 2020
@Mi-Lan Mi-Lan added this to the Version 1.2.0 milestone Nov 10, 2020
@pimato pimato modified the milestones: Version 1.2.3, Version 1.2.4 Feb 17, 2021
@Mi-Lan
Copy link
Contributor Author

Mi-Lan commented Feb 17, 2021

I will merge conflicts here once we are ready for merge with subgraph since there are changes made on the chart component which has different structure now with the changes...i'm assuming that the change is related to kadens calculations consolidation since i think one relates to function used in charts....

Copy link
Contributor

@kadenzipfel kadenzipfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on a super tough feature 👏

Copy link
Contributor

@pimato pimato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network: xDai
Looks like at some point the history transaction list stopped loading new markets:
Bildschirmaufnahme 2021-02-26 um 14 44 38

For this market:
http://localhost:3000/#/0xd3f61725f4a1905223160abec29b98e81cd569ba

Error message:
Bildschirmfoto 2021-02-26 um 14 47 54

@pimato
Copy link
Contributor

pimato commented Feb 26, 2021

Disabled button is not according our design specification for disabled buttons:
Bildschirmfoto 2021-02-26 um 14 53 29

Should:
Bildschirmfoto 2021-02-26 um 14 53 38

@pimato
Copy link
Contributor

pimato commented Feb 26, 2021

Active buttons should not have onHover styling:
Bildschirmfoto 2021-02-26 um 14 55 08

@pimato
Copy link
Contributor

pimato commented Feb 26, 2021

All in the dropdown should be renamed to All Activities and the collapsed modal should have the same width as the dropdown button:
Bildschirmfoto 2021-02-26 um 14 55 43

Should:
Bildschirmfoto 2021-02-26 um 14 55 35

@pimato
Copy link
Contributor

pimato commented Feb 26, 2021

Every hyperlink should have a hover styling with color #5C6BC0
Bildschirmfoto 2021-02-26 um 14 59 55

@pimato pimato self-requested a review March 1, 2021 09:58
Copy link
Contributor

@pimato pimato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like I get an error while trying to load only Trading Activities in the History tab.

Market: http://localhost:3000/#/0x09ba10798a54f8830e3568a000e55981c493f043
Network: xDai

Bildschirmfoto 2021-03-01 um 10 59 06

Bildschirmfoto 2021-03-01 um 10 57 49

@pimato pimato self-requested a review March 1, 2021 14:19
@Mi-Lan Mi-Lan merged commit 8540dc6 into master Mar 1, 2021
@Mi-Lan Mi-Lan deleted the feature/#1194 branch March 1, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Transaction Overview to History Tab
6 participants