Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/proposal details small fixes #2238

Draft
wants to merge 8 commits into
base: feature/2044
Choose a base branch
from

Conversation

Mi-Lan
Copy link
Contributor

@Mi-Lan Mi-Lan commented Sep 3, 2021

TO DO:

  • connect data to votes section bar
    Screenshot 2021-09-03 at 18 03 06
  • find where we fetch data for quorum and total votes and votes on individual

@Mi-Lan Mi-Lan changed the base branch from master to feature/2044 September 3, 2021 16:02
@Mi-Lan Mi-Lan marked this pull request as draft September 3, 2021 16:02
@Mi-Lan Mi-Lan requested a review from hexyls September 6, 2021 13:35
@Mi-Lan
Copy link
Contributor Author

Mi-Lan commented Sep 6, 2021

@hexyls To make it easier to review Ill just explain what i did.

  1. Based on geronimos feedback the progress bar here should be percentage of total votes and the prick should be quorum amount.
    Screenshot 2021-09-06 at 15 41 40
  1. This button should reflect current proposal state
    Screenshot 2021-09-06 at 15 46 10

WDYT?

Copy link
Contributor

@hexyls hexyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good to me.

atm looks like quorum is set to 100% atm but I tested with different quorum values it works really well 👍

and yeah it does look like we need different button states depending on proposal state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants