Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): fix transaction builder pattern #67

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

KovacZan
Copy link
Contributor

@KovacZan KovacZan commented Feb 3, 2021

… have to be first

Summary

This PR fixes transaction builder pattern.

What changes are being made?

I changed that extended generic is of type abstract builder not abstract guardian builder.

Why are these changes necessary?

 const actual = new GuardianGroupPermissionsBuilder()
                .vendorField("guardian-group-permissions transaction")
                .nonce("4")
                .GuardianGroupPermissions(groupPermission)
                .sign(passphrases[0]!);

Make it possible to use asset method anywhere you want before build or sign.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@KovacZan KovacZan merged commit e24d86b into develop Feb 3, 2021
@KovacZan KovacZan deleted the fix/builder branch February 3, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants