-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alt text enhancements #2550
Comments
When ready:
|
@kevindherman @lukefretwell this is up in Beta for testing. @kevindherman what specifically did you mean when you asked for a link to better documentation? I'm not sure where I would put that. |
@curtismchale awesome. I'm trying to get the first scan going but it's just spinning. Are you able to generate a scan? For documentation, I think the idea was to add links to support articles. There will likely be a future article for the specific tool but for now, this is the newest and best alt text article: https://help.proudcity.com/alt-text-and-accessible-images/ @lukefretwell I think you had more specific ideas on helpful doc placement? Maybe it's phase 1 using the existing article to get this out and then we add more useful documentation down the line. |
@curtismchale Beta has a lot of images and my guess is that many don't have alt text so I wonder if the size of the scan is part of the issue. Scanning San Rafael and Petaluma respectively took a couple of goes. |
@kevindherman @lukefretwell so this still isn't quite running on Beta, but it doe work on another test site. I assume that @kevindherman idea above is correct, there are lots of images on For now check out the other test site to verify that this works as expected. |
@curtismchale @lukefretwell this is great. Dashboard: @curtismchale are we able to limit to just alt text missing? That could be a good phase 1 and then the other items we could role out later if @lukefretwell is concerned about freaking people out with a big number of issues when alt text missing is the main problem. Total images |
I'm not as concerned about the number of images causing alarm. Would be great to understand (and see) what we can hide per specs here: #2550 (comment) |
@lukefretwell it looks like everything was edited out from your comments. Do you think this message/alert should also be edited out? |
@kevindherman yes |
@kevindherman I'm not sure that the amount of images is the problem with Beta. I just ran it on my site with 3500 images and it took about 1 minute to run. It showed progress within about 10 seconds. I'm deploying to proudcity now to test there again to see if the image processing works. I don't think we should limit the report either. It's possible with CSS to hid things, but it's just a list of items so I have to use CSS that counts the items. If they ever change the order or add one item the CSS isn't going to work as we expect. I think we should focus on education, good alt text is a requirement they have to meet. I don't think hiding the issue serves customers well at all. Ballpark image numbersWe know that 3500 work on my site. I just ran it locally on a client site with 4500 images and it worked fine. I'm grabbing a copy of a client site with 11k images to test as well. That's taking a bit so I'll update if it doesn't work. What we hide@lukefretwell we hide everything you asked for except the bell icon because I missed that arrow. I'll do that now. We only hide that if you're not a WordPress Administrator. I know there is 1 or 2 customers that have this access but for the vast majority, everything you wanted is hidden. I'll do a new build shortly to hide the bell as well. |
I'm totally fine with not limited the report, it was just discussed previously. Sounds like we could be close to getting out. |
Builds
Issue
Source
The source of the issue (ex: Customer: #CustomerName#).
ProudCity
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Only to make certain items invisible to admins.
What feature would you like to improve
A clear and concise description of the current feature.
Hide:
Describe the solution you'd like
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.
Current settings:
Settings tab:
Notices:
Warning:
Deploy
The text was updated successfully, but these errors were encountered: