Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to create topic with custom parameters #7

Closed
germanosin opened this issue Feb 27, 2020 · 4 comments
Closed

Add an ability to create topic with custom parameters #7

germanosin opened this issue Feb 27, 2020 · 4 comments
Assignees
Projects

Comments

@germanosin
Copy link
Contributor

germanosin commented Feb 27, 2020

  • Provide a list of available topic parameters with default values
  • Update the topic creation endpoint to use list of custom parameters
  • Validate custom parameters
@germanosin germanosin added this to To do in Kafka UI Feb 27, 2020
@workshur workshur changed the title Create topic with custom topic parameters Add an ability to create topic with custom parameters Feb 27, 2020
@workshur workshur removed their assignment Feb 27, 2020
@Gataniel
Copy link
Contributor

Gataniel commented Apr 13, 2020

#20 - ui part PR
#27 - ui part PR
#14 - ui part issue

https://github.com/provectus/kafka-ui/blob/master/kafka-ui-react-app/src/components/Topics/New/CustomParams/customParamsOptions.tsx - file with ALL available custom parameters with default values. Created it myself - I might have missed something - feel free to update

@Gataniel
Copy link
Contributor

Gataniel commented Apr 13, 2020

  1. update backend topic creation API to handle custom params
    the schema is the following

Screenshot 2020-04-13 at 12 53 26

{..., configs: { ..., customParams: { 'timestamp1': { name: customParamName, value: customParamValue }, 'timestamp2': { name: customParamName2, value: customParamValue2 }, ... }, }, }

  1. add validation for custom params(
    no empty values,
    no invalid values(strings for ints, etc),
    no duplicate values
    )

@yazebochan yazebochan moved this from To do to In progress in Kafka UI Apr 27, 2020
@germanosin
Copy link
Contributor Author

  1. update backend topic creation API to handle custom params
    the schema is the following
Screenshot 2020-04-13 at 12 53 26

{..., configs: { ..., customParams: { 'timestamp1': { name: customParamName, value: customParamValue }, 'timestamp2': { name: customParamName2, value: customParamValue2 }, ... }, }, }

  1. add validation for custom params(
    no empty values,
    no invalid values(strings for ints, etc),
    no duplicate values
    )

Why do we need ` timestamp in custom params map?
```customParams: { 'timestamp1' ``

@Gataniel
Copy link
Contributor

@germanosin thats outdated. Custom params now are simply under config = { ... customParams } just with other options

@germanosin germanosin moved this from In progress to Done in Kafka UI Apr 28, 2020
gitbook-com bot pushed a commit that referenced this issue Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Kafka UI
  
Done
Development

No branches or pull requests

5 participants