Feature/14 add custom params for topics creation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMoRRoMa
approved these changes
Apr 9, 2020
workshur
reviewed
Apr 9, 2020
|
|
||
| interface Props { | ||
| onClick: (event: React.MouseEvent<HTMLButtonElement>) => void, | ||
| btnColor: string; |
There was a problem hiding this comment.
- <CustomParamButton btnColor="is-danger" btnIcon='fa-minus' onClick={() => onRemove(index)} />
+ <CustomParamButton
+ className="is-danger"
+ type='minus'
+ onClick={() => onRemove(index)}
+/>enum CustomParamButtonType {
plus=
minus=
}
interface Props {
onClick: (event: React.MouseEvent<HTMLButtonElement>) => void,
className: string;
type: CustomParamButtonType;
}There was a problem hiding this comment.
good suggestion! thanks!
| </> | ||
| ); | ||
|
|
||
| export default React.memo(CustomParamOptions); |
| const optInputName = `${index}[name]`; | ||
|
|
||
| React.useEffect( | ||
| () => { if (isFirstParam(index)) { unregister(optInputName) } }, |
There was a problem hiding this comment.
let me add it in a separate task =)
| ); | ||
|
|
||
| const selectedMustBeUniq = (selected: string) => { | ||
| const values: any = getValues({ nest: true }); |
| const { register, unregister, errors, watch, setValue } = useFormContext(); | ||
| const selectInputName: string = `${index}[name]`; | ||
| const valInputName: string = `${index}[value]`; | ||
| const selectedParamName: any = watch(selectInputName, name); |
There was a problem hiding this comment.
I'm a typescript newbie =) Not sure how to handle this if things like watch(), getValues() return undefined
which is ok?
const selectedParamName = watch(selectInputName, name);
const selectedParamName: string = watch(selectInputName, name);
but if I do this way, I start getting typescript warnings like: Type 'uknown' is not assignable to type 'string' or Type 'unknown' cannot be used as an index type.
Please do suggest a correct option
| import CustomParamValue from './CustomParamValue'; | ||
| import CustomParamAction from './CustomParamAction'; | ||
|
|
||
| const DEF_INDEX = 'default'; |
workshur
approved these changes
Apr 13, 2020
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
…params-for-topics-creation Feature/14 add custom params for topics creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14