Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessagesServiceTest:maskingAppliedOnConfiguredClusters fix #3287

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Jan 31, 2023

MessagesServiceTest.maskingAppliedOnConfiguredClusters : waiting of kafka write added

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@iliax iliax requested a review from a team as a code owner January 31, 2023 06:47
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 31, 2023
@Haarolean Haarolean added scope/backend type/chore Boring stuff, could be refactoring or tech debt and removed status/triage Issues pending maintainers triage labels Jan 31, 2023
@Haarolean Haarolean added this to the 0.6 milestone Jan 31, 2023
@Haarolean Haarolean merged commit d1f04e0 into master Jan 31, 2023
@Haarolean Haarolean deleted the masking_test_stabilization branch January 31, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants