Add ability to use custom basePath #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustamGimadiev
added
type/enhancement
|
Hi @RustamGimadiev. Does it solves #364 (comment) ? |
|
hi @andormarkus yes, this PR will solve that issue, now need to do some frontend works to fix broken links in the sidebar, I guess the ALB ingress controller will also get working, now we test it with nginx without rewrite rules |
RustamGimadiev
force-pushed
the
fix-relative-path
branch
from
3d9f20c
to
91b5d7a
Compare
RustamGimadiev
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed!
|
andormarkus
pushed a commit
to andormarkus/kafka-ui
that referenced
this pull request
Jun 4, 2021
…sePath is used than Helm chart livenessProbe and readinessProbe will fail because it will try to probe on the default path which does not exist anymore. With these changes it automatically picks up `SERVER_SERVLET_CONTEXT_PATH` from the myconfig.yaml and sets correct path for livenessProbe and readinessProbe
13 tasks
RustamGimadiev
pushed a commit
that referenced
this pull request
Jul 2, 2021
… used than Helm chart livenessProbe and readinessProbe will fail because it will try to probe on the default path which does not exist anymore. With these changes it automatically picks up `SERVER_SERVLET_CONTEXT_PATH` from the myconfig.yaml and sets correct path for livenessProbe and readinessProbe
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
* add ability to use relative pathes * Add basename prop (provectus#513) * add static controller * add docker-compose * Refactoring * Refactoring * fixed comparison bugs * dirty * clenaup * Update React app Co-authored-by: Alexander Krivonosov <31561808+GneyHabub@users.noreply.github.com> Co-authored-by: German Osin <german.osin@gmail.com> Co-authored-by: Oleg Shuralev <workshur@gmail.com>
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
…sePath is used than Helm chart livenessProbe and readinessProbe will fail because it will try to probe on the default path which does not exist anymore. With these changes it automatically picks up `SERVER_SERVLET_CONTEXT_PATH` from the myconfig.yaml and sets correct path for livenessProbe and readinessProbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
These changes will resolve #364, to test this deployment case need to execute
docker compose up -f docker/kafka-ui-reverse-proxy.yaml, it simulates the same behavior as ingress with custom basePath in K8sHow Has This Been Tested? (put an "X" next to an item)
Checklist (put an "X" next to an item, otherwise PR will fail)
Check out Contributing and Code of Conduct