Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basename prop #513

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Add basename prop #513

merged 1 commit into from
Jun 1, 2021

Conversation

GneyHabub
Copy link
Contributor

Add basename prop to the BrowserRouter

@workshur
Copy link
Member

workshur commented Jun 1, 2021

Please check how history.push cases work

@GneyHabub GneyHabub closed this Jun 1, 2021
@GneyHabub GneyHabub reopened this Jun 1, 2021
@GneyHabub
Copy link
Contributor Author

Please check how history.push cases work

Seem to be working perfectly fine👌

@RustamGimadiev RustamGimadiev merged commit 1ea9255 into fix-relative-path Jun 1, 2021
@RustamGimadiev RustamGimadiev deleted the fix-left-nav-links branch June 1, 2021 15:16
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

workshur added a commit that referenced this pull request Jun 3, 2021
* add ability to use relative pathes

* Add basename prop (#513)

* add static controller

* add docker-compose

* Refactoring

* Refactoring

* fixed comparison bugs

* dirty

* clenaup

* Update React app

Co-authored-by: Alexander Krivonosov <31561808+GneyHabub@users.noreply.github.com>
Co-authored-by: German Osin <german.osin@gmail.com>
Co-authored-by: Oleg Shuralev <workshur@gmail.com>
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* add ability to use relative pathes

* Add basename prop (provectus#513)

* add static controller

* add docker-compose

* Refactoring

* Refactoring

* fixed comparison bugs

* dirty

* clenaup

* Update React app

Co-authored-by: Alexander Krivonosov <31561808+GneyHabub@users.noreply.github.com>
Co-authored-by: German Osin <german.osin@gmail.com>
Co-authored-by: Oleg Shuralev <workshur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants