Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgFees Module 50/50 Fee Split on MsgAssessCustomMsgFeeRequest Removal #1263

Closed
4 tasks
hyperschwartz opened this issue Dec 14, 2022 · 1 comment · Fixed by #1267
Closed
4 tasks

MsgFees Module 50/50 Fee Split on MsgAssessCustomMsgFeeRequest Removal #1263

hyperschwartz opened this issue Dec 14, 2022 · 1 comment · Fixed by #1267
Assignees
@arnabmitra
Labels
msgfees Msg based fee module
Milestone
v1.14.0

Comments

@hyperschwartz
Copy link

Summary

The current process for assessing a custom fee via the MsgAssessCustomMsgFeeRequest msg takes 50% of the amount charged and sends it to Provenance. This fee should be removed.

Problem Definition

This is a planned change, and this issue is to ensure that this change is tracked.

Proposal

The code that currently subtracts 50% of the fees sent should be removed, and the comments on the MsgAssessCustomMsgFeeRequest in the proto definition stating that this behavior in place should be removed.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@arnabmitra arnabmitra self-assigned this Dec 14, 2022
arnabmitra added a commit that referenced this issue Dec 15, 2022
@arnabmitra
#1263 implement as per request, still keeping bips as an option but f…
c50f8cb 
…or now it all goes to the recipient, see comment // AssessCustomMsgFeeBips is the bips the recipient will get

	// This should be a message level data (present in TypeAssessCustomMsgFee = assess_custom_msg_fee) i think so that it can be defined by the smart contract writer
	// or at the very least it can be a module param.
	// for now i am hard coding it to avoid breaking any clients and because of this ticket #1263
	AssessCustomMsgFeeBips = 10_000
This was referenced Dec 15, 2022
Merged
Closed
arnabmitra added a commit that referenced this issue Dec 16, 2022
@arnabmitra @kwtalley
Send full custom msg fee to recipient instead of 50/50 split with mod…
64fe65a 
…ule. (#1267)

* #1263 implement as per request, still keeping bips as an option but for now it all goes to the recipient, see comment // AssessCustomMsgFeeBips is the bips the recipient will get
	// This should be a message level data (present in TypeAssessCustomMsgFee = assess_custom_msg_fee) i think so that it can be defined by the smart contract writer
	// or at the very least it can be a module param.
	// for now i am hard coding it to avoid breaking any clients and because of this ticket #1263
	AssessCustomMsgFeeBips = 10_000

* minor fixes.

* adding changelog.

* updating comment.

* updating comments based on PR.

* update wasm encoder param comment

Co-authored-by: Ken Talley <4344285+kwtalley@users.noreply.github.com>
@nullpointer0x00 nullpointer0x00 mentioned this issue Jan 9, 2023
Merged
8 tasks
@nullpointer0x00 nullpointer0x00 added the msgfees Msg based fee module label Jan 9, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.14.0 milestone Jan 9, 2023
@nullpointer0x00
Copy link
Contributor

Was finished with PR #1267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnabmitra arnabmitra

Labels
msgfees Msg based fee module
Projects
Provenance Core Protocol Team
Archived in project
Milestone
v1.14.0
Development

Successfully merging a pull request may close this issue.

Send full custom msg fee to recipient instead of 50/50 split with module. provenance-io/provenance
3 participants
@arnabmitra @nullpointer0x00 @hyperschwartz