Send full custom msg fee to recipient instead of 50/50 split with module. #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or now it all goes to the recipient, see comment // AssessCustomMsgFeeBips is the bips the recipient will get // This should be a message level data (present in TypeAssessCustomMsgFee = assess_custom_msg_fee) i think so that it can be defined by the smart contract writer // or at the very least it can be a module param. // for now i am hard coding it to avoid breaking any clients and because of this ticket #1263 AssessCustomMsgFeeBips = 10_000
arnabmitra
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 58.46% 58.47%
=======================================
Files 206 206
Lines 25264 25274 +10
=======================================
+ Hits 14771 14779 +8
- Misses 9398 9400 +2
Partials 1095 1095
|
iramiller
reviewed
Dec 15, 2022
SpicyLemon
previously approved these changes
Dec 15, 2022
SpicyLemon
changed the title
iramiller
approved these changes
Dec 16, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR implements #1263 …per request, still keeping bips as an option but for now it all goes to the recipient, see comment on AssessCustomMsgFeeBips
created follow up issue if we want to still have some kind of split in the future #1268
Description
closes: #1263
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes