update wasmd to v0.51.0 #2045
update wasmd to v0.51.0 #2045
Conversation
|
Warning Rate limit exceeded@kwtalley has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 42 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis update primarily revolves around upgrading the Provenance blockchain to support Cosmosm 2.0. Major changes include updating import paths to Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (10)
docker/blockchain/Dockerfile (2)
Line range hint
6-6: Consider pinning versions inapt-get installto ensure consistent environments across builds.- apt-get install -y libleveldb-dev + apt-get install -y libleveldb-dev=<specific_version>Tools
Hadolint
[info] 46-46: Double quote to prevent globbing and word splitting. (SC2086)
Line range hint
6-6: Use--no-install-recommendsto avoid installing unnecessary packages.- apt-get install -y libleveldb-dev + apt-get install -y --no-install-recommends libleveldb-devTools
Hadolint
[info] 46-46: Double quote to prevent globbing and word splitting. (SC2086)
Makefile (1)
Line range hint
400-401: Review the detected API key to ensure it's not exposing sensitive operations.CHANGELOG.md (7)
Line range hint
208-465: Consider using consistent list item markers in markdown lists.- - + *
Line range hint
187-187: Multiple consecutive blank lines detected. Consider reducing to a single blank line for better readability.- +Also applies to: 929-929, 1330-1330, 1347-1347, 1503-1503
Line range hint
1325-1325: Multiple spaces detected after the hash in the ATX style heading.- ## Features + ## Features
Line range hint
865-865: Multiple headings with the same content detected. Consider revising the headings to make them unique or consolidate the sections if they are meant to be the same.Also applies to: 906-906, 1200-1200
Line range hint
340-340: Bare URLs detected. Consider using markdown link syntax to improve readability and presentation.- https://github.com/provenance-io/provenance/issues/1015 + [Issue #1015](https://github.com/provenance-io/provenance/issues/1015)Also applies to: 371-371, 470-470, 520-520, 532-532, 548-548, 619-619, 630-630, 638-638, 674-674, 699-699, 711-711, 757-757, 758-758, 759-759, 760-760, 761-761, 808-808, 849-849, 902-902, 1015-1015
Line range hint
1057-1057: Spaces detected inside emphasis markers. Consider removing spaces for correct emphasis rendering.- * feature * + *feature*
Line range hint
453-453: Spaces detected inside code span elements. Consider removing spaces for correct code rendering.- ` code ` + `code`
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (8)
- .golangci.yml (1 hunks)
- CHANGELOG.md (1 hunks)
- Makefile (1 hunks)
- app/app.go (1 hunks)
- docker/blockchain/Dockerfile (1 hunks)
- go.mod (2 hunks)
- internal/provwasm/query_plugins.go (1 hunks)
- internal/provwasm/stargate_whitelist.go (1 hunks)
Files skipped from review due to trivial changes (3)
- .golangci.yml
- internal/provwasm/query_plugins.go
- internal/provwasm/stargate_whitelist.go
Additional context used
Hadolint
docker/blockchain/Dockerfile
[warning] 6-6: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 6-6: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[info] 36-36: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[warning] 36-36: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 46-46: Double quote to prevent globbing and word splitting. (SC2086)
Gitleaks
Makefile
400-401: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)
Markdownlint
CHANGELOG.md
208-208: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
209-209: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
210-210: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
211-211: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
212-212: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
213-213: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
305-305: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
306-306: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
307-307: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
308-308: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
309-309: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
310-310: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
311-311: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
312-312: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
313-313: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
314-314: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
315-315: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
316-316: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
317-317: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
318-318: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
319-319: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
320-320: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
321-321: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
322-322: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
323-323: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
324-324: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
325-325: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
326-326: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
327-327: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
328-328: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
329-329: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
330-330: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
331-331: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
332-332: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
333-333: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
334-334: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
335-335: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
336-336: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
367-367: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
444-444: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
445-445: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
446-446: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
447-447: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
448-448: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
449-449: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
450-450: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
451-451: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
452-452: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
453-453: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
454-454: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
457-457: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
458-458: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
459-459: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
460-460: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
461-461: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
462-462: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
463-463: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
464-464: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
465-465: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
466-466: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
822-822: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
830-830: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
875-875: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
883-883: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
187-187: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
929-929: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1330-1330: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1347-1347: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1399-1399: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1503-1503: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1325-1325: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading
865-865: null (MD024, no-duplicate-heading)
Multiple headings with the same content
906-906: null (MD024, no-duplicate-heading)
Multiple headings with the same content
1200-1200: null (MD024, no-duplicate-heading)
Multiple headings with the same content
340-340: null (MD034, no-bare-urls)
Bare URL used
371-371: null (MD034, no-bare-urls)
Bare URL used
470-470: null (MD034, no-bare-urls)
Bare URL used
520-520: null (MD034, no-bare-urls)
Bare URL used
532-532: null (MD034, no-bare-urls)
Bare URL used
548-548: null (MD034, no-bare-urls)
Bare URL used
619-619: null (MD034, no-bare-urls)
Bare URL used
630-630: null (MD034, no-bare-urls)
Bare URL used
638-638: null (MD034, no-bare-urls)
Bare URL used
674-674: null (MD034, no-bare-urls)
Bare URL used
699-699: null (MD034, no-bare-urls)
Bare URL used
711-711: null (MD034, no-bare-urls)
Bare URL used
757-757: null (MD034, no-bare-urls)
Bare URL used
758-758: null (MD034, no-bare-urls)
Bare URL used
759-759: null (MD034, no-bare-urls)
Bare URL used
760-760: null (MD034, no-bare-urls)
Bare URL used
761-761: null (MD034, no-bare-urls)
Bare URL used
808-808: null (MD034, no-bare-urls)
Bare URL used
849-849: null (MD034, no-bare-urls)
Bare URL used
902-902: null (MD034, no-bare-urls)
Bare URL used
1015-1015: null (MD034, no-bare-urls)
Bare URL used
1057-1057: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
1057-1057: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
453-453: null (MD038, no-space-in-code)
Spaces inside code span elements
Additional comments not posted (5)
docker/blockchain/Dockerfile (1)
43-43: Ensure the updated path aligns with the new directory structure forwasmvm v2.go.mod (2)
19-20: Update towasmd v0.51.0andwasmvm v2.0.0aligns with the objectives to support CosmWasm 2.0.
214-214: Ensure the replaced versionv0.51.0-pio-1ofwasmdis correctly tagged and available in the repository.Makefile (1)
226-226: Update the path for copyinglibwasmvmto reflect the new version directory.app/app.go (1)
649-649: Added "cosmwasm_2_0" to supported features to accommodate the new version of CosmWasm.
kwtalley
force-pushed
the
kwtalley/update-wasmd-v0.51.0
branch
3 times, most recently
from
9c6abfa
to
4d7dd33
Compare
kwtalley
force-pushed
the
kwtalley/update-wasmd-v0.51.0
branch
from
8bf64a2
to
7029d23
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range and nitpick comments (11)
docker/blockchain/Dockerfile (1)
Line range hint
6-6: Pin package versions and use--no-install-recommends.To avoid unexpected updates and minimize the size of the image, consider pinning the versions of packages installed with
apt-get installand using--no-install-recommendto reduce the number of unnecessary packages.- apt-get install -y curl jq libleveldb-dev + apt-get install -y curl=7.64.0-4+deb10u2 jq=1.5+dfsg-2+b1 libleveldb-dev=1:1.20-2 --no-install-recommendsAlso applies to: 36-36
Tools
Hadolint
[info] 46-46: Double quote to prevent globbing and word splitting. (SC2086)
networks/ibc/blockchain-ibc/Dockerfile (1)
Line range hint
27-27: Pin package versions and use--no-install-recommends.To avoid unexpected updates and minimize the size of the image, consider pinning the versions of packages installed with
apt-get installand using--no-install-recommendto reduce the number of unnecessary packages.- apt-get install -y curl jq + apt-get install -y curl=7.64.0-4+deb10u2 jq=1.5+dfsg-2+b1 --no-install-recommendsAlso applies to: 76-76
networks/local/blockchain-local/Dockerfile (1)
Line range hint
27-27: Pin package versions and use--no-install-recommends.To avoid unexpected updates and minimize the size of the image, consider pinning the versions of packages installed with
apt-get installand using--no-install-recommendto reduce the number of unnecessary packages.- apt-get install -y curl jq + apt-get install -y curl=7.64.0-4+deb10u2 jq=1.5+dfsg-2+b1 --no-install-recommendsAlso applies to: 76-76
networks/dev/blockchain-dev/Dockerfile (1)
Line range hint
26-26: Pin package versions and use--no-install-recommends.To avoid unexpected updates and minimize the size of the image, consider pinning the versions of packages installed with
apt-get installand using--no-install-recommendto reduce the number of unnecessary packages.- apt-get install -y curl jq + apt-get install -y curl=7.64.0-4+deb10u2 jq=1.5+dfsg-2+b1 --no-install-recommendsAlso applies to: 72-72
CHANGELOG.md (7)
Line range hint
209-465: Consistency in list item markers:
The list items in the changelog should consistently use asterisks (*) instead of dashes (-) to maintain consistency and adhere to Markdown best practices. Please update all list markers accordingly.- - + *
Line range hint
188-188: Remove extra blank lines:
There are multiple instances where consecutive blank lines are used. According to Markdown best practices, it's recommended to use a single blank line to separate sections for better readability and to adhere to the Markdown lint rules.-Also applies to: 931-931, 1332-1332, 1349-1349, 1505-1505
Line range hint
1327-1327: Remove extra spaces in heading:
There are multiple spaces after the hash in the Markdown heading, which is not necessary and could lead to formatting issues in some Markdown renderers.- ## Heading + ## Heading
Line range hint
867-867: Avoid duplicate headings:
Duplicate headings can cause confusion and issues with navigation in the document. It's best to ensure each heading is unique or adjust the headings to reflect different subsections if needed.Also applies to: 908-908, 1202-1202
Line range hint
342-342: Enclose bare URLs in Markdown syntax:
Bare URLs should be enclosed in angle brackets or using Markdown link syntax to ensure they are clickable and more readable within the document.- http://example.com + <http://example.com>Also applies to: 373-373, 472-472, 522-522, 534-534, 550-550, 621-621, 632-632, 640-640, 676-676, 701-701, 713-713, 759-763, 810-810, 851-851, 904-904, 1017-1017
Line range hint
1059-1059: Remove spaces inside emphasis markers:
Spaces inside emphasis markers can lead to incorrect rendering. Ensure that there are no spaces immediately inside the asterisks used for emphasis.- * incorrect emphasis * + *correct emphasis*
Line range hint
455-455: Remove spaces inside code spans:
Spaces inside code span elements can lead to incorrect rendering. Ensure that there are no spaces immediately inside the backticks used for code spans.- ` code ` + `code`
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (17)
- .golangci.yml (1 hunks)
- CHANGELOG.md (1 hunks)
- Makefile (1 hunks)
- app/app.go (1 hunks)
- docker/blockchain/Dockerfile (1 hunks)
- go.mod (2 hunks)
- internal/provwasm/query_plugins.go (1 hunks)
- internal/provwasm/stargate_whitelist.go (1 hunks)
- networks/dev/blockchain-dev/Dockerfile (2 hunks)
- networks/ibc/blockchain-ibc/Dockerfile (2 hunks)
- networks/local/blockchain-local/Dockerfile (2 hunks)
- third_party/proto/cosmwasm/wasm/v1/authz.proto (3 hunks)
- third_party/proto/cosmwasm/wasm/v1/proposal_legacy.proto (6 hunks)
- third_party/proto/cosmwasm/wasm/v1/query.proto (3 hunks)
- third_party/proto/cosmwasm/wasm/v1/tx.proto (7 hunks)
- third_party/proto/cosmwasm/wasm/v1/types.proto (1 hunks)
- x/oracle/keeper/mocks_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- .golangci.yml
- app/app.go
- go.mod
- internal/provwasm/query_plugins.go
- internal/provwasm/stargate_whitelist.go
Additional context used
Hadolint
docker/blockchain/Dockerfile
[warning] 6-6: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 6-6: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[info] 36-36: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[warning] 36-36: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 46-46: Double quote to prevent globbing and word splitting. (SC2086)
networks/ibc/blockchain-ibc/Dockerfile
[warning] 27-27: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 27-27: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[info] 76-76: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[warning] 76-76: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)networks/local/blockchain-local/Dockerfile
[warning] 27-27: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 27-27: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[info] 76-76: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[warning] 76-76: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)networks/dev/blockchain-dev/Dockerfile
[warning] 26-26: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 26-26: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[info] 72-72: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[warning] 72-72: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
Gitleaks
Makefile
400-401: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)
Markdownlint
CHANGELOG.md
209-209: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
210-210: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
211-211: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
212-212: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
213-213: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
307-307: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
308-308: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
309-309: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
310-310: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
311-311: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
312-312: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
313-313: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
314-314: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
315-315: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
316-316: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
317-317: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
318-318: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
319-319: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
320-320: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
321-321: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
322-322: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
323-323: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
324-324: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
325-325: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
326-326: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
327-327: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
328-328: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
329-329: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
330-330: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
331-331: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
332-332: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
333-333: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
334-334: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
335-335: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
336-336: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
337-337: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
338-338: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
367-367: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
446-446: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
447-447: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
448-448: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
449-449: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
450-450: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
451-451: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
452-452: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
453-453: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
454-454: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
457-457: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
458-458: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
459-459: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
460-460: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
461-461: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
462-462: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
463-463: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
464-464: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
465-465: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
466-466: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
467-467: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
468-468: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
824-824: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
832-832: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
877-877: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
885-885: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
188-188: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
931-931: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1332-1332: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1349-1349: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1401-1401: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1505-1505: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1327-1327: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading
867-867: null (MD024, no-duplicate-heading)
Multiple headings with the same content
908-908: null (MD024, no-duplicate-heading)
Multiple headings with the same content
1202-1202: null (MD024, no-duplicate-heading)
Multiple headings with the same content
342-342: null (MD034, no-bare-urls)
Bare URL used
373-373: null (MD034, no-bare-urls)
Bare URL used
472-472: null (MD034, no-bare-urls)
Bare URL used
522-522: null (MD034, no-bare-urls)
Bare URL used
534-534: null (MD034, no-bare-urls)
Bare URL used
550-550: null (MD034, no-bare-urls)
Bare URL used
621-621: null (MD034, no-bare-urls)
Bare URL used
632-632: null (MD034, no-bare-urls)
Bare URL used
640-640: null (MD034, no-bare-urls)
Bare URL used
676-676: null (MD034, no-bare-urls)
Bare URL used
701-701: null (MD034, no-bare-urls)
Bare URL used
713-713: null (MD034, no-bare-urls)
Bare URL used
759-759: null (MD034, no-bare-urls)
Bare URL used
760-760: null (MD034, no-bare-urls)
Bare URL used
761-761: null (MD034, no-bare-urls)
Bare URL used
762-762: null (MD034, no-bare-urls)
Bare URL used
763-763: null (MD034, no-bare-urls)
Bare URL used
810-810: null (MD034, no-bare-urls)
Bare URL used
851-851: null (MD034, no-bare-urls)
Bare URL used
904-904: null (MD034, no-bare-urls)
Bare URL used
1017-1017: null (MD034, no-bare-urls)
Bare URL used
1059-1059: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
1059-1059: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
455-455: null (MD038, no-space-in-code)
Spaces inside code span elements
Additional comments not posted (23)
x/oracle/keeper/mocks_test.go (2)
20-22: Approved new mock method addition.The addition of the
BuildAddressmock method aligns with the changes in the Wasm module to support new functionalities. This mock will be useful for unit testing.
23-25: Good practice: Dependency Injection in Testing.The method
WithWasmQueryServerallows for dependency injection of a Wasm query server, which is a good practice for testing and modularity.third_party/proto/cosmwasm/wasm/v1/types.proto (1)
127-130: Approved protobuf field enhancement.The addition of
inline_jsonencoding to themsgfield inContractCodeHistoryEntryenhances the handling of JSON-formatted messages, aligning with the needs of more complex data interactions in smart contracts.third_party/proto/cosmwasm/wasm/v1/authz.proto (3)
103-104: Approved encoding specification for backward compatibility.The addition of
legacy_coinsencoding to theamountsfield inMaxFundsLimitensures compatibility with existing financial systems and standards.
122-123: Approved encoding specification for combined limits.The
legacy_coinsencoding added to theamountsfield inCombinedLimitensures consistent handling of financial data across different parts of the application.
157-160: Approved enhancement for message filtering flexibility.The addition of
inline_jsonencoding to themessagesfield inAcceptedMessagesFilterallows for more complex and structured data to be processed, enhancing the flexibility and capability of message filtering.third_party/proto/cosmwasm/wasm/v1/query.proto (3)
75-80: Approved addition of new RPC methodBuildAddress.The new
BuildAddressRPC method enhances the querying capabilities of the Wasm module by allowing users to construct contract addresses based on specific parameters. This is a valuable addition for developers interacting with smart contracts.
180-183: Approved enhancement to query data handling.The addition of
inline_jsonencoding to thequery_datafield inQuerySmartContractStateRequestallows for more complex and structured query data to be processed, enhancing the querying capabilities of smart contracts.
190-193: Approved consistent data handling in smart contract queries.The addition of
inline_jsonencoding to thedatafield inQuerySmartContractStateResponseensures consistency with the request structure and enhances the handling of complex JSON data in responses.third_party/proto/cosmwasm/wasm/v1/proposal_legacy.proto (6)
70-79: Updated encoding specifications in InstantiateContractProposalThe encoding for the
msgandfundsfields inInstantiateContractProposalhave been updated to"inline_json"and"legacy_coins"respectively. This change aligns with the new requirements for CosmWasm 2.0, ensuring compatibility with the latest encoding standards.
105-114: Updated encoding specifications in InstantiateContract2ProposalSimilar to the previous comment, the
msgandfundsfields inInstantiateContract2Proposalnow use"inline_json"and"legacy_coins"encodings. This consistency across related messages is crucial for maintaining uniform behavior and compatibility.
143-146: Updated encoding for MigrateContractProposalThe
msgfield inMigrateContractProposalhas been updated to use"inline_json"encoding. This change is part of the broader update to support CosmWasm 2.0, ensuring that message encoding is consistent across different contract operations.
165-168: Updated encoding for SudoContractProposalThe
msgfield inSudoContractProposalnow uses"inline_json"encoding. This update ensures that the contract's sudo operations are compatible with the new encoding standards required by CosmWasm 2.0.
189-198: Updated encoding in ExecuteContractProposalThe
msgandfundsfields inExecuteContractProposalhave been updated to"inline_json"and"legacy_coins"respectively. These updates are essential for ensuring that the execution of contracts is compatible with the new encoding standards introduced in CosmWasm 2.0.
336-345: Updated encoding in StoreAndInstantiateContractProposalThe
msgandfundsfields inStoreAndInstantiateContractProposalhave been updated to"inline_json"and"legacy_coins"respectively. This update is crucial for ensuring that the storage and instantiation of contracts comply with the new encoding standards required by CosmWasm 2.0.Makefile (1)
226-226: Updated path for copyinglibwasmvmlibraryThe path for copying the
libwasmvmlibrary has been updated to reflect the new version directory (v2). This change is necessary to ensure that the build process uses the correct version of the library, consistent with the upgrade towasmvm v2.0.0.third_party/proto/cosmwasm/wasm/v1/tx.proto (7)
126-135: Addition of Amino Encoding SpecificationsThe addition of
(amino.encoding) = "inline_json"for themsgfield and(amino.encoding) = "legacy_coins"for thefundsfield in theMsgInstantiateContractmessage is consistent with the PR objectives to support CosmWasm 2.0. This should ensure the correct serialization format is used for compatibility with the updated version.
162-171: Addition of Amino Encoding SpecificationsSimilar to the
MsgInstantiateContract, theMsgInstantiateContract2also includes the addition of encoding attributes. This ensures that themsgandfundsfields are serialized in a manner compatible with the updated CosmWasm version. This change is aligned with the PR's goal of updating to wasmd v0.51.0.
[APROVED]
198-207: Addition of Amino Encoding SpecificationsThe
MsgExecuteContractmessage has been updated to include encoding specifications for themsgandfundsfields. These changes are crucial for ensuring that the data is correctly serialized and deserialized when interacting with smart contracts under the new CosmWasm 2.0 specifications.
229-232: Addition of Amino Encoding SpecificationsThe
MsgMigrateContractmessage'smsgfield now includes the(amino.encoding) = "inline_json"attribute. This update is necessary for the migration operations to be compatible with the new serialization requirements introduced in CosmWasm 2.0.
324-327: Addition of Amino Encoding SpecificationsFor the
MsgSudoContract, the encoding specification(amino.encoding) = "inline_json"has been added to themsgfield. This change is essential for ensuring that the contract's sudo operations are compatible with the new serialization standards.
405-415: Addition of Amino Encoding SpecificationsThe
MsgStoreAndInstantiateContractmessage now includes encoding specifications for both themsgandfundsfields. These updates are consistent with the other changes across the file, ensuring compatibility with the serialization requirements of CosmWasm 2.0.
488-491: Addition of Amino Encoding SpecificationsFinally, the
MsgStoreAndMigrateContractmessage has been updated to include the(amino.encoding) = "inline_json"for themsgfield. This change ensures that the message data is correctly serialized according to the new standards required by CosmWasm 2.0.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (7)
CHANGELOG.md (7)
Line range hint
208-238: NITPICK: Use consistent list markers in Markdown.In the Markdown file, replace dashes (
-) with asterisks (*) for list items to maintain consistency as per the Markdownlint suggestion. Here is an example of how you can adjust it:- Incorrect + CorrectAlso applies to: 308-338, 368-370, 447-469, 825-825, 833-833, 878-878, 886-886
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
187-187: NITPICK: Remove multiple consecutive blank lines.Consecutive blank lines can be reduced to a single blank line to adhere to best practices in Markdown formatting.
Also applies to: 932-932, 1333-1333, 1350-1350, 1402-1402, 1506-1506
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
1328-1328: NITPICK: Remove multiple spaces after hash in ATX style heading.There should be only one space after the hash symbols in ATX style headings for proper Markdown formatting.
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
868-868: NITPICK: Avoid duplicate headings.Ensure that headings are unique within the document to improve readability and navigation.
Also applies to: 909-909, 1203-1203
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
343-343: NITPICK: Avoid using bare URLs.Wrap URLs in Markdown links to improve the readability and appearance of the document. For example:
[Link Text](https://example.com)Also applies to: 374-374, 473-473, 523-523, 535-535, 551-551, 622-622, 633-633, 641-641, 677-677, 702-702, 714-714, 760-764, 811-811, 852-852, 905-905, 1018-1018
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
1060-1060: NITPICK: Remove spaces inside emphasis markers.Ensure there are no spaces next to the asterisks used for emphasis in Markdown.
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
456-456: NITPICK: Remove spaces inside code span elements.Spaces inside code spans can affect the formatting and should be removed.
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md
208-208: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
209-209: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
210-210: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
211-211: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
212-212: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
213-213: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
308-308: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
309-309: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
310-310: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
311-311: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
312-312: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
313-313: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
314-314: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
315-315: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
316-316: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
317-317: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
318-318: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
319-319: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
320-320: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
321-321: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
322-322: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
323-323: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
324-324: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
325-325: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
326-326: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
327-327: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
328-328: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
329-329: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
330-330: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
331-331: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
332-332: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
333-333: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
334-334: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
335-335: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
336-336: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
337-337: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
338-338: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
339-339: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
447-447: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
448-448: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
449-449: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
450-450: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
451-451: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
452-452: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
453-453: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
454-454: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
457-457: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
458-458: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
459-459: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
460-460: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
461-461: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
462-462: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
463-463: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
464-464: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
465-465: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
466-466: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
467-467: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
468-468: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
469-469: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
825-825: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
833-833: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
878-878: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
886-886: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
187-187: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
932-932: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1333-1333: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1350-1350: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1402-1402: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1506-1506: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1328-1328: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading
868-868: null (MD024, no-duplicate-heading)
Multiple headings with the same content
909-909: null (MD024, no-duplicate-heading)
Multiple headings with the same content
1203-1203: null (MD024, no-duplicate-heading)
Multiple headings with the same content
343-343: null (MD034, no-bare-urls)
Bare URL used
374-374: null (MD034, no-bare-urls)
Bare URL used
473-473: null (MD034, no-bare-urls)
Bare URL used
523-523: null (MD034, no-bare-urls)
Bare URL used
535-535: null (MD034, no-bare-urls)
Bare URL used
551-551: null (MD034, no-bare-urls)
Bare URL used
622-622: null (MD034, no-bare-urls)
Bare URL used
633-633: null (MD034, no-bare-urls)
Bare URL used
641-641: null (MD034, no-bare-urls)
Bare URL used
677-677: null (MD034, no-bare-urls)
Bare URL used
702-702: null (MD034, no-bare-urls)
Bare URL used
714-714: null (MD034, no-bare-urls)
Bare URL used
760-760: null (MD034, no-bare-urls)
Bare URL used
761-761: null (MD034, no-bare-urls)
Bare URL used
762-762: null (MD034, no-bare-urls)
Bare URL used
763-763: null (MD034, no-bare-urls)
Bare URL used
764-764: null (MD034, no-bare-urls)
Bare URL used
811-811: null (MD034, no-bare-urls)
Bare URL used
852-852: null (MD034, no-bare-urls)
Bare URL used
905-905: null (MD034, no-bare-urls)
Bare URL used
1018-1018: null (MD034, no-bare-urls)
Bare URL used
1060-1060: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
1060-1060: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
456-456: null (MD038, no-space-in-code)
Spaces inside code span elements
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (7)
CHANGELOG.md (7)
Line range hint
208-238: NITPICK: Use consistent list markers in Markdown.For better consistency in Markdown files, it's recommended to use a consistent style for list markers. The expected style is asterisks (
*), but dashes (-) are used in several places. Consider updating all list markers to use asterisks.- - Bump `github.com/CosmWasm/wasmd` from v0.50.0 + * Bump `github.com/CosmWasm/wasmd` from v0.50.0 ...Also applies to: 308-338, 368-370, 447-469, 825-825, 833-833, 878-878, 886-886
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
187-187: NITPICK: Remove extra blank lines.Multiple consecutive blank lines found, which could affect readability and consistency of the document's formatting. Consider reducing to a single blank line.
- - +Also applies to: 932-932, 1333-1333, 1350-1350, 1402-1402, 1506-1506
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
1328-1328: NITPICK: Remove multiple spaces after hash in Markdown heading.Multiple spaces after the hash in an ATX style heading can lead to formatting issues in some Markdown parsers. It's recommended to have only one space.
- ## Some Heading + ## Some HeadingTools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
868-868: NITPICK: Avoid duplicate headings in Markdown.Multiple headings with the same content can confuse readers and disrupt the document structure. Consider revising the headings to make them unique or combining sections under a single heading.
Also applies to: 909-909, 1203-1203
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
343-343: NITPICK: Replace bare URLs with Markdown links for better readability.Bare URLs in the document can be harder to read and less accessible. Consider using Markdown links to improve the document's readability and presentation.
- https://github.com/provenance-io/provenance/issues/123 + [Issue #123](https://github.com/provenance-io/provenance/issues/123)Also applies to: 374-374, 473-473, 523-523, 535-535, 551-551, 622-622, 633-633, 641-641, 677-677, 702-702, 714-714, 760-764, 811-811, 852-852, 905-905, 1018-1018
Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
1060-1060: NITPICK: Remove spaces inside emphasis markers in Markdown.Spaces inside emphasis markers can lead to unexpected formatting. It's recommended to remove any spaces immediately inside the emphasis markers.
- * some emphasized text * + *some emphasized text*Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Line range hint
456-456: NITPICK: Remove spaces inside code span elements in Markdown.Spaces inside code span elements can lead to unexpected formatting. It's recommended to remove any spaces immediately inside the code span markers.
- ` some code ` + `some code`Tools
Markdownlint
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
Markdownlint
CHANGELOG.md
208-208: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
209-209: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
210-210: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
211-211: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
212-212: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
213-213: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
308-308: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
309-309: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
310-310: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
311-311: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
312-312: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
313-313: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
314-314: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
315-315: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
316-316: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
317-317: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
318-318: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
319-319: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
320-320: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
321-321: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
322-322: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
323-323: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
324-324: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
325-325: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
326-326: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
327-327: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
328-328: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
329-329: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
330-330: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
331-331: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
332-332: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
333-333: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
334-334: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
335-335: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
336-336: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
337-337: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
338-338: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
339-339: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
447-447: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
448-448: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
449-449: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
450-450: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
451-451: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
452-452: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
453-453: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
454-454: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
457-457: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
458-458: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
459-459: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
460-460: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
461-461: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
462-462: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
463-463: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
464-464: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
465-465: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
466-466: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
467-467: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
468-468: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
469-469: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
825-825: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
833-833: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
878-878: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
886-886: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
187-187: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
932-932: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1333-1333: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1350-1350: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1402-1402: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1506-1506: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1328-1328: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading
868-868: null (MD024, no-duplicate-heading)
Multiple headings with the same content
909-909: null (MD024, no-duplicate-heading)
Multiple headings with the same content
1203-1203: null (MD024, no-duplicate-heading)
Multiple headings with the same content
343-343: null (MD034, no-bare-urls)
Bare URL used
374-374: null (MD034, no-bare-urls)
Bare URL used
473-473: null (MD034, no-bare-urls)
Bare URL used
523-523: null (MD034, no-bare-urls)
Bare URL used
535-535: null (MD034, no-bare-urls)
Bare URL used
551-551: null (MD034, no-bare-urls)
Bare URL used
622-622: null (MD034, no-bare-urls)
Bare URL used
633-633: null (MD034, no-bare-urls)
Bare URL used
641-641: null (MD034, no-bare-urls)
Bare URL used
677-677: null (MD034, no-bare-urls)
Bare URL used
702-702: null (MD034, no-bare-urls)
Bare URL used
714-714: null (MD034, no-bare-urls)
Bare URL used
760-760: null (MD034, no-bare-urls)
Bare URL used
761-761: null (MD034, no-bare-urls)
Bare URL used
762-762: null (MD034, no-bare-urls)
Bare URL used
763-763: null (MD034, no-bare-urls)
Bare URL used
764-764: null (MD034, no-bare-urls)
Bare URL used
811-811: null (MD034, no-bare-urls)
Bare URL used
852-852: null (MD034, no-bare-urls)
Bare URL used
905-905: null (MD034, no-bare-urls)
Bare URL used
1018-1018: null (MD034, no-bare-urls)
Bare URL used
1060-1060: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
1060-1060: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
456-456: null (MD038, no-space-in-code)
Spaces inside code span elements
There was a problem hiding this comment.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- app/app.go (2 hunks)
- app/app_test.go (1 hunks)
- docker/blockchain/Dockerfile (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/app.go
Additional context used
Hadolint
docker/blockchain/Dockerfile
[warning] 6-6: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 6-6: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[info] 36-36: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[warning] 36-36: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[error] 46-46: This cp has no destination. Check the arguments. (SC2225)
Additional comments not posted (1)
app/app_test.go (1)
58-59: Approve the handling ofwasmvmdata directory lockfile contention.The changes introduce a new temporary directory for each test case to avoid lockfile contention in the
wasmvmdata directory. This is a good practice for ensuring that test cases do not interfere with each other when accessing external resources.
kwtalley
force-pushed
the
kwtalley/update-wasmd-v0.51.0
branch
from
a3675bc
to
3ff003d
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
docker/blockchain/Dockerfile (2)
Line range hint
6-6: Pin package versions and use--no-install-recommends.To ensure reproducibility and minimize the size of the Docker image, pin versions in
apt-get installcommands and use--no-install-recommendsto avoid installing unnecessary packages.- apt-get install -y libleveldb-dev + apt-get install -y libleveldb-dev=<version> --no-install-recommends
Line range hint
36-36: Pin package versions and use--no-install-recommends.Similar to an earlier comment, ensure package versions are pinned and unnecessary packages are avoided in the run stage.
- apt-get install -y curl jq libleveldb-dev + apt-get install -y curl=<version> jq=<version> libleveldb-dev=<version> --no-install-recommends
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/docker.yml (1 hunks)
- app/sim_test.go (4 hunks)
- docker/blockchain/Dockerfile (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/docker.yml
Additional context used
Hadolint
docker/blockchain/Dockerfile
[warning] 6-6: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
[info] 6-6: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[info] 36-36: Avoid additional packages by specifying
--no-install-recommends(DL3015)
[warning] 36-36: Pin versions in apt get install. Instead of
apt-get install <package>useapt-get install <package>=<version>(DL3008)
Additional comments not posted (7)
docker/blockchain/Dockerfile (4)
43-43: Update tolibwasmvmpath approved.The change correctly reflects the new version path for
libwasmvm. The use of double quotes around shell variables is also correctly implemented.
51-51: Proper usage of shell commands in Dockerfile.The
cpcommand correctly uses double quotes to prevent globbing and word splitting, adhering to shell scripting best practices.
51-51: Environment setup approved.Setting
PIO_HOMEand the working directory are standard practices for configuring Docker containers.
51-51: Correct configuration of exposed ports and command.The
EXPOSEandCMDdirectives are correctly used to configure the container's network settings and default behavior.app/sim_test.go (3)
369-369: Create a temporary directory to avoid lockfile contention.The addition of creating a temporary directory to resolve lockfile contention is a practical solution to avoid issues during parallel test execution.
Also applies to: 501-501
369-369: Proper handling of application state export and import in tests.The implementation of state export and import testing is crucial for verifying the integrity of state transitions in blockchain applications.
Also applies to: 501-501
577-577: Address lockfile contention for simulation tests.Creating a new temporary directory for each simulation run is a good practice to avoid data directory lockfile contention, especially in parallel testing environments.
Description
This PR updates wasmd to the latest v0.51.0-pio-1 to support CosmWasm 2.0
closes: #2044
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
BuildAddressfor contract address generation.Bug Fixes
wasmvmdata.Chores
wasmvm/v2across multiple files.WASMVM_REPOin GitHub workflow to correct path.Documentation
wasmdandwasmvmand added information on stargate queries and a new circuit breaker module.