-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add msgfees module to added store upgrades #638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iramiller
previously approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, definitely need this one.
arnabmitra
previously approved these changes
Feb 8, 2022
channa-figure
dismissed stale reviews from arnabmitra and iramiller
via
February 9, 2022 17:51
6363ac4
channa-figure
requested review from
dwedul-figure,
egaxhaj and
fkneeland-figure
as code owners
February 9, 2022 17:53
iramiller
approved these changes
Feb 9, 2022
arnabmitra
approved these changes
Feb 9, 2022
4 tasks
fkneeland-figure
pushed a commit
that referenced
this pull request
Feb 22, 2022
* Add msgfees to store added upgrades * Add changelog entry
dwedul-figure
added a commit
that referenced
this pull request
Mar 16, 2022
* add java distribution (#625) (#628) * add java distribution * update changelog * Backport scope/attributes, gov deposit, and java distribution changes (#636) * add java distribution (#625) * add java distribution * update changelog * Update gov module deposit requirements and add msg fee (#633) * add deposit and msg fee updates for gov in upgrade * changelog * Allow attributes to be associated with scopes. (#634) * [631]: Update NewAttribute to take in a string instead of an AccAddress. * [631]: Update Attribute.ValidateBasic() to allow the address to be a scope metadata address. * [631]: Update NewMsgAddAttributeRequest to take in a string for the account instead of an AccAddress in order to allow for scope metadata addresses. * [631]: Update NewMsgUpdateAttributeRequest to take in a string for the account instead of an AccAddress in order to allow for scope metadata addresses. * [631]: Update the attribute keeper methods to treat the Address as a string instead of AccAddress to allow it to be a scope metadata address. * [631]: Update the attribute keys methods to not rely on the address being an account address. * [631]: Lint fixes. * [631]: Lint fixes in main that make lint is complaining about. * [631]: Add changelog entry. * [631]: Add some stuff that was missed like the delete messages and some extra context on returned errors. * Fix message breaking unit test Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> Co-authored-by: Ira Miller <72319+iramiller@users.noreply.github.com> Co-authored-by: Ergels Gaxhaj <87285445+egaxhaj-figure@users.noreply.github.com> Co-authored-by: Daniel Wedul <72031080+dwedul-figure@users.noreply.github.com> Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> * Add msgfees module to added store upgrades (#638) * Add msgfees to store added upgrades * Add changelog entry * 614 proto binding support with buf build (#630) (#641) * 614 proto binding support with buf build (#630) * initial attemp at using buf.build * buf.build stuff * buf workflow * trigger on PR for testing * fix breaking for third_party * use existing workflow * updated proto steps * changelog entry * fix bug with proto-all * update proto script and protos * update proto-all task * fix typo * fix bug with proto binding release version & combine workflows * add protoBinding build step to release.yml workflow * missed in git add on last commit * fix lint errors * fix buf braking * fix for incorrect line endings (#644) * add needs: build_init (#646) (#647) * Add base denom to nhash, Add change log (#649) * Fix maven publish release version reference (#652) * fix release version reference * update changelog * Bump cosmwasm from v1.0.0-beta5 to v1.0.0-beta6 (#656) * Bump cosmwasm from v1.0.0-beta5 to v1.0.0-beta6, Add change log entry * Add dockerfile cosmoswasm v1.0.0-beta5 direct download and validation * Revert dockerfile changes * Port iterator fix to v1.8 (#660) * Add iterator as a feature to wasm * new upgrade handler hazel. (#661) * remove v from artifact version (#654) (#657) * remove v from artifact version * update changelog * Fix contract address length support (#663) * Change go.mod to use wasmd fork to support old address length * Linked issue * adding upgrade handler indigo. (#665) * adding upgrade handler indigo. * Go lint fixes (#698) Upgrade golangci-lint and fix lint errors * backport tx gas limits #681 (#704) * backport: In release 1.8(not yet in mainnet), floor gas price should … (#705) * backport: In release 1.8(not yet in mainnet), floor gas price should be checked for all Tx's ( currently only being checked for Tx which have additional Msg Fee),closes: #684 * fix owner array initialization size when creating scope mutation message from wasm contracts * Simulation tests for smart contracts (#673) * simulation tests are running * fixed record issue * Add smart contract to github actions testing * fixed determinism test * cleanup * make format * cleanup * make format * lint changes * more lint fixes * fix tests * reordered sims tests * working on import tests * fixed tests * cleanup * add changelog * fix test name * make format * update linter * lint error * fix append errors * lint fixes * update lint version * print line numbers * use verbose output * use work around for linter * reverted name change * more clenaup * nolint comments * more nolint comments * updated linter for kErr * update golint version * nolint for gosec * make format * remove unused consts * nolint cleanups * make format * update action version * revert action change * Add jasmine upgrade handler (#713) * Skip max gas fees if tx contains MsgSubmitProposal msg (#711) * Add jasmine upgrade handler * fix lint errors and run make format. * Adjustments for v1.8.0 release (#717) * pre rc10 (new handler, gas fee 15/blk, ante reorder) Co-authored-by: arnabmitra <arnabmitra.mitra@gmail.com> * Add some underscores to a couple large numbers. Co-authored-by: Ergels Gaxhaj <87285445+egaxhaj-figure@users.noreply.github.com> Co-authored-by: Ira Miller <72319+iramiller@users.noreply.github.com> Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> Co-authored-by: Carlton Hanna <73041609+channa-figure@users.noreply.github.com> Co-authored-by: fkneeland-figure <86616427+fkneeland-figure@users.noreply.github.com> Co-authored-by: Arnab Mitra <arnabmitra.mitra@gmail.com> Co-authored-by: Ken Talley <ktalley@figure.com> Co-authored-by: Ken Talley <76671864+ktalley-figure@users.noreply.github.com>
dwedul-figure
added a commit
that referenced
this pull request
Apr 22, 2022
* add java distribution (#625) (#628) * add java distribution * update changelog * Backport scope/attributes, gov deposit, and java distribution changes (#636) * add java distribution (#625) * add java distribution * update changelog * Update gov module deposit requirements and add msg fee (#633) * add deposit and msg fee updates for gov in upgrade * changelog * Allow attributes to be associated with scopes. (#634) * [631]: Update NewAttribute to take in a string instead of an AccAddress. * [631]: Update Attribute.ValidateBasic() to allow the address to be a scope metadata address. * [631]: Update NewMsgAddAttributeRequest to take in a string for the account instead of an AccAddress in order to allow for scope metadata addresses. * [631]: Update NewMsgUpdateAttributeRequest to take in a string for the account instead of an AccAddress in order to allow for scope metadata addresses. * [631]: Update the attribute keeper methods to treat the Address as a string instead of AccAddress to allow it to be a scope metadata address. * [631]: Update the attribute keys methods to not rely on the address being an account address. * [631]: Lint fixes. * [631]: Lint fixes in main that make lint is complaining about. * [631]: Add changelog entry. * [631]: Add some stuff that was missed like the delete messages and some extra context on returned errors. * Fix message breaking unit test Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> Co-authored-by: Ira Miller <72319+iramiller@users.noreply.github.com> Co-authored-by: Ergels Gaxhaj <87285445+egaxhaj-figure@users.noreply.github.com> Co-authored-by: Daniel Wedul <72031080+dwedul-figure@users.noreply.github.com> Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> * Add msgfees module to added store upgrades (#638) * Add msgfees to store added upgrades * Add changelog entry * 614 proto binding support with buf build (#630) (#641) * 614 proto binding support with buf build (#630) * initial attemp at using buf.build * buf.build stuff * buf workflow * trigger on PR for testing * fix breaking for third_party * use existing workflow * updated proto steps * changelog entry * fix bug with proto-all * update proto script and protos * update proto-all task * fix typo * fix bug with proto binding release version & combine workflows * add protoBinding build step to release.yml workflow * missed in git add on last commit * fix lint errors * fix buf braking * fix for incorrect line endings (#644) * add needs: build_init (#646) (#647) * Add base denom to nhash, Add change log (#649) * Fix maven publish release version reference (#652) * fix release version reference * update changelog * Bump cosmwasm from v1.0.0-beta5 to v1.0.0-beta6 (#656) * Bump cosmwasm from v1.0.0-beta5 to v1.0.0-beta6, Add change log entry * Add dockerfile cosmoswasm v1.0.0-beta5 direct download and validation * Revert dockerfile changes * Port iterator fix to v1.8 (#660) * Add iterator as a feature to wasm * new upgrade handler hazel. (#661) * remove v from artifact version (#654) (#657) * remove v from artifact version * update changelog * Fix contract address length support (#663) * Change go.mod to use wasmd fork to support old address length * Linked issue * adding upgrade handler indigo. (#665) * adding upgrade handler indigo. * Go lint fixes (#698) Upgrade golangci-lint and fix lint errors * backport tx gas limits #681 (#704) * backport: In release 1.8(not yet in mainnet), floor gas price should … (#705) * backport: In release 1.8(not yet in mainnet), floor gas price should be checked for all Tx's ( currently only being checked for Tx which have additional Msg Fee),closes: #684 * fix owner array initialization size when creating scope mutation message from wasm contracts * Simulation tests for smart contracts (#673) * simulation tests are running * fixed record issue * Add smart contract to github actions testing * fixed determinism test * cleanup * make format * cleanup * make format * lint changes * more lint fixes * fix tests * reordered sims tests * working on import tests * fixed tests * cleanup * add changelog * fix test name * make format * update linter * lint error * fix append errors * lint fixes * update lint version * print line numbers * use verbose output * use work around for linter * reverted name change * more clenaup * nolint comments * more nolint comments * updated linter for kErr * update golint version * nolint for gosec * make format * remove unused consts * nolint cleanups * make format * update action version * revert action change * Add jasmine upgrade handler (#713) * Skip max gas fees if tx contains MsgSubmitProposal msg (#711) * Add jasmine upgrade handler * Adjustments for v1.8.0 release (#717) * pre rc10 (new handler, gas fee 15/blk, ante reorder) Co-authored-by: arnabmitra <arnabmitra.mitra@gmail.com> * Use go version 1.17 for the lint action. (#725) * Use provwasm release artifact for smart contract tests (#732) * Add script to download latest provwasm smart contract and require it in tests * cleanup and changelog * Bump IBC to v2.2.0 and update github actions. (#734) * Update the github workflows with version changes that were made to master. * Bump ibc-go to v2.2.0 (from v2.0.2). This change has already been made in master, just bringing it in here too. * Update the CHANGELOG to reflect the 1.8.0 release. (#764) * Updates required for Cosmos SDK 0.45.3 and ADR-038 (#782) * updates required for cosmos sdk upgrade * improve changelog * improve issue description * enable adr 038 state listening * fix goimports lint error * panic on error * v1.0.0-beta4 not yet released * copy missing mk file * update changelog * Fix import missed during merge. * Remove duplicate TestSimple that was accidentally added during the merge. * Switch the new TestAppStateDeterminismWithStateListening to use the new PrintConfig and PrintStats funcs. * Fix another bad merge thing. * Update the download_smart_contracts.sh script with the correct version. * Revert "Update the download_smart_contracts.sh script with the correct version." This reverts commit ad2c890. Turns out beta3 is correct. Co-authored-by: Ira Miller <72319+iramiller@users.noreply.github.com> Co-authored-by: Daniel Wedul <72031080+dwedul-figure@users.noreply.github.com> Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> Co-authored-by: Carlton Hanna <73041609+channa-figure@users.noreply.github.com> Co-authored-by: fkneeland-figure <86616427+fkneeland-figure@users.noreply.github.com> Co-authored-by: Arnab Mitra <arnabmitra.mitra@gmail.com> Co-authored-by: Ken Talley <ktalley@figure.com> Co-authored-by: Ken Talley <76671864+ktalley-figure@users.noreply.github.com> Co-authored-by: Daniel Wedul <dwedul@figure.com>
dwedul-figure
added a commit
that referenced
this pull request
Apr 25, 2022
* add java distribution (#625) (#628) * add java distribution * update changelog * Backport scope/attributes, gov deposit, and java distribution changes (#636) * add java distribution (#625) * add java distribution * update changelog * Update gov module deposit requirements and add msg fee (#633) * add deposit and msg fee updates for gov in upgrade * changelog * Allow attributes to be associated with scopes. (#634) * [631]: Update NewAttribute to take in a string instead of an AccAddress. * [631]: Update Attribute.ValidateBasic() to allow the address to be a scope metadata address. * [631]: Update NewMsgAddAttributeRequest to take in a string for the account instead of an AccAddress in order to allow for scope metadata addresses. * [631]: Update NewMsgUpdateAttributeRequest to take in a string for the account instead of an AccAddress in order to allow for scope metadata addresses. * [631]: Update the attribute keeper methods to treat the Address as a string instead of AccAddress to allow it to be a scope metadata address. * [631]: Update the attribute keys methods to not rely on the address being an account address. * [631]: Lint fixes. * [631]: Lint fixes in main that make lint is complaining about. * [631]: Add changelog entry. * [631]: Add some stuff that was missed like the delete messages and some extra context on returned errors. * Fix message breaking unit test Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> Co-authored-by: Ira Miller <72319+iramiller@users.noreply.github.com> Co-authored-by: Ergels Gaxhaj <87285445+egaxhaj-figure@users.noreply.github.com> Co-authored-by: Daniel Wedul <72031080+dwedul-figure@users.noreply.github.com> Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> * Add msgfees module to added store upgrades (#638) * Add msgfees to store added upgrades * Add changelog entry * 614 proto binding support with buf build (#630) (#641) * 614 proto binding support with buf build (#630) * initial attemp at using buf.build * buf.build stuff * buf workflow * trigger on PR for testing * fix breaking for third_party * use existing workflow * updated proto steps * changelog entry * fix bug with proto-all * update proto script and protos * update proto-all task * fix typo * fix bug with proto binding release version & combine workflows * add protoBinding build step to release.yml workflow * missed in git add on last commit * fix lint errors * fix buf braking * fix for incorrect line endings (#644) * add needs: build_init (#646) (#647) * Add base denom to nhash, Add change log (#649) * Fix maven publish release version reference (#652) * fix release version reference * update changelog * Bump cosmwasm from v1.0.0-beta5 to v1.0.0-beta6 (#656) * Bump cosmwasm from v1.0.0-beta5 to v1.0.0-beta6, Add change log entry * Add dockerfile cosmoswasm v1.0.0-beta5 direct download and validation * Revert dockerfile changes * Port iterator fix to v1.8 (#660) * Add iterator as a feature to wasm * new upgrade handler hazel. (#661) * remove v from artifact version (#654) (#657) * remove v from artifact version * update changelog * Fix contract address length support (#663) * Change go.mod to use wasmd fork to support old address length * Linked issue * adding upgrade handler indigo. (#665) * adding upgrade handler indigo. * Go lint fixes (#698) Upgrade golangci-lint and fix lint errors * backport tx gas limits #681 (#704) * backport: In release 1.8(not yet in mainnet), floor gas price should … (#705) * backport: In release 1.8(not yet in mainnet), floor gas price should be checked for all Tx's ( currently only being checked for Tx which have additional Msg Fee),closes: #684 * fix owner array initialization size when creating scope mutation message from wasm contracts * Simulation tests for smart contracts (#673) * simulation tests are running * fixed record issue * Add smart contract to github actions testing * fixed determinism test * cleanup * make format * cleanup * make format * lint changes * more lint fixes * fix tests * reordered sims tests * working on import tests * fixed tests * cleanup * add changelog * fix test name * make format * update linter * lint error * fix append errors * lint fixes * update lint version * print line numbers * use verbose output * use work around for linter * reverted name change * more clenaup * nolint comments * more nolint comments * updated linter for kErr * update golint version * nolint for gosec * make format * remove unused consts * nolint cleanups * make format * update action version * revert action change * Add jasmine upgrade handler (#713) * Skip max gas fees if tx contains MsgSubmitProposal msg (#711) * Add jasmine upgrade handler * Adjustments for v1.8.0 release (#717) * pre rc10 (new handler, gas fee 15/blk, ante reorder) Co-authored-by: arnabmitra <arnabmitra.mitra@gmail.com> * Use go version 1.17 for the lint action. (#725) * Use provwasm release artifact for smart contract tests (#732) * Add script to download latest provwasm smart contract and require it in tests * cleanup and changelog * Bump IBC to v2.2.0 and update github actions. (#734) * Update the github workflows with version changes that were made to master. * Bump ibc-go to v2.2.0 (from v2.0.2). This change has already been made in master, just bringing it in here too. * Update the CHANGELOG to reflect the 1.8.0 release. (#764) * Updates required for Cosmos SDK 0.45.3 and ADR-038 (#782) * updates required for cosmos sdk upgrade * improve changelog * improve issue description * upgrade cosmos 0.45.3-pio-2 for 11707 bugfix (#795) * Include ADR-038 fixes in 1.8.x (#797) * enable adr 038 state listening * fix goimports lint error * panic on error * v1.0.0-beta4 not yet released * copy missing mk file * update changelog Co-authored-by: Ergels Gaxhaj <egaxhaj@figure.com> * add changelog entries for 1.8.2 (#796) * Add the dynamic tag when running unit tests on M1s. * Fix bad merge in go.mod. * Fix the changelog. * Further small tweaks to the changelog. Co-authored-by: Ergels Gaxhaj <87285445+egaxhaj-figure@users.noreply.github.com> Co-authored-by: Ira Miller <72319+iramiller@users.noreply.github.com> Co-authored-by: Derek Adams <dadams@figure.com> Co-authored-by: Derek Adams <derek.adams@sitewhere.com> Co-authored-by: Carlton Hanna <73041609+channa-figure@users.noreply.github.com> Co-authored-by: fkneeland-figure <86616427+fkneeland-figure@users.noreply.github.com> Co-authored-by: Arnab Mitra <arnabmitra.mitra@gmail.com> Co-authored-by: Ken Talley <ktalley@figure.com> Co-authored-by: Ken Talley <76671864+ktalley-figure@users.noreply.github.com> Co-authored-by: Ergels Gaxhaj <egaxhaj@figure.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
green
upgrade handler was missing the declaration of new storemsgfees
. This prevented the iavl version for msgfees not to be set to the current height.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes