Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance secrets group: Find secrets in EC2 Auto Scaling Launch Template #852

Closed
kamiryo opened this issue Aug 19, 2021 · 5 comments · Fixed by #4076
Closed

Enhance secrets group: Find secrets in EC2 Auto Scaling Launch Template #852

kamiryo opened this issue Aug 19, 2021 · 5 comments · Fixed by #4076
Labels
feature-request New feature request for Prowler.

Comments

@kamiryo
Copy link
Contributor

kamiryo commented Aug 19, 2021

I'm having issues with "[extra775] Find secrets in EC2 Auto Scaling Launch Configuration".
I checked the script of extra775, and I think it uses the secretsDetector to check the UserData inside the launch-configuration, but I also feel that there should be a rule to check the UserData inside the launch-template. However, I feel a rule to check UserData in launch-template is also necessary.
(I feel that creating a new one with different rules would be a good idea.)

Reference:
https://docs.aws.amazon.com/autoscaling/ec2/userguide/LaunchTemplates.html

We recommend that you use launch templates to ensure that you're accessing the latest features and improvements. Not all Amazon EC2 Auto Scaling features are available when you use launch configurations. Not all Amazon EC2 Auto Scaling features are available when you use launch configurations.

@w0rmr1d3r
Copy link
Contributor

Thank you @kamiryo , I believe this issue is somehow duplicated (or just adding more info) to this other one -> #422

Cheers!

@toniblyx
Copy link
Member

toniblyx commented Nov 8, 2021

@kamiryo can you confirm where could those credentials could be stored? extra775 search for them at LaunchConfigurations[*].UserData. What else UserData inside the launch-template? I don't see that in docs.

@toniblyx toniblyx changed the title Find secrets in EC2 Auto Scaling (Launch Template) Enhance secrets group: Find secrets in EC2 Auto Scaling Launch Template Nov 9, 2021
@toniblyx toniblyx added feature-request New feature request for Prowler. need information labels Nov 9, 2021
@jfagoagas
Copy link
Member

Hi @kamiryo, can you provide us more information about this issue?

@jfagoagas jfagoagas added status/awaiting-reponse Waiting response from Issue owner and removed need information labels Feb 15, 2022
@jfagoagas
Copy link
Member

Hi @kamiryo, we are closing this issue. Please, feel free to reopen it if you can provide more information.

Thanks!

@jfagoagas jfagoagas removed the status/awaiting-reponse Waiting response from Issue owner label Jun 29, 2022
@rieck-srlabs
Copy link
Contributor

@jfagoagas Might make sense to reopen this while work on PR #4076 is ongoing.

@jfagoagas jfagoagas reopened this May 23, 2024
sergargar added a commit that referenced this issue May 27, 2024
Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request for Prowler.
Projects
None yet
5 participants