Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EC2): New EC2 AWS check (#852) #4074

Closed
wants to merge 2 commits into from
Closed

feat(EC2): New EC2 AWS check (#852) #4074

wants to merge 2 commits into from

Conversation

rieck-srlabs
Copy link
Contributor

Adds check to find exposed secrets in EC2 Launch Templates. Currently, Prowler does not scan EC2 Launch Templates.

Context

The existing check autoscaling_find_secrets_ec2_launch_configuration only considers EC2 AutoScaling launch configurations, which are deprecated and can no longer be created. The replacement feature - Launch Templates - is currently not checked by Prowler. However, just like launch configurations, launch templates can also contain UserData that might include secrets.

Issue #852 raised this issue in 2021 but failed to result in relevant changes to Prowler. The issue was closed due to inactivity.

Description

  • Updates the EC2 service to include launch templates, including all versions.
  • Adds check to search for secrets in EC2 launch templates
  • Adds relevant tests for EC2 service and added check
  • Adds new check to relevant compliance benchmarks, where autoscaling_find_secrets_ec2_launch_configuration was included already.
  • Updates the pentesting.md tutorial document.

Fixes #852

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds check to find exposed secrets in EC2 Launch Templates
@rieck-srlabs rieck-srlabs requested review from a team May 23, 2024 14:07
@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider labels May 23, 2024
@jfagoagas
Copy link
Member

Hi @rieck-srlabs why did you close it?

Thanks!

@rieck-srlabs
Copy link
Contributor Author

@jfagoagas, had some trouble with flake8. Lets continue in the new PR (#4076)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance secrets group: Find secrets in EC2 Auto Scaling Launch Template
2 participants