feat(assume-role): Properly handle External ID variable #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toniblyx
added
status/waiting-for-revision
jfagoagas
approved these changes
May 5, 2022
There was a problem hiding this comment.
Good catch @chrisdlangton. Thank you very much for your contribution.
jfagoagas
changed the title
jfagoagas
removed
the
status/waiting-for-revision
jfagoagas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
3.0-dev branch has an alternative patch
for master branch, the external id is simply broken. this quick change of 2 characters keeps all existing code as-is and ensure the master branch functions as was always intended
Description
The fix is that the
--external-idjust needs to be an treated as argument, not a string literal as it currently is. The only way a literal can work is if the string is run througheval, which it isn't, and usingevalfor something easily avoided (as this PR shows) is not advisableLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.