Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(securityhub): Add validation and handle errors #3590

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

jfagoagas
Copy link
Member

Description

  • Add validation for the Description and Remediation.Recommendation.Text
  • Create the models for Remediation and Recommendation
  • Handle errors when calling the Security Hub API
  • Improve tests

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested a review from a team March 22, 2024 07:20
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (74aaeaa) to head (c156cfc).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           prowler-4.0-dev    #3590      +/-   ##
===================================================
- Coverage            86.20%   86.18%   -0.03%     
===================================================
  Files                  704      704              
  Lines                21663    21687      +24     
===================================================
+ Hits                 18674    18690      +16     
- Misses                2989     2997       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@sergargar sergargar merged commit 487190b into prowler-4.0-dev Mar 22, 2024
10 of 11 checks passed
@sergargar sergargar deleted the add-validation-for-json-asff branch March 22, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants