Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(securityhub): Remove region from exception match #3593

Conversation

jfagoagas
Copy link
Member

Description

Remove in region {region} since that part may not be present in the API error.

This PR doesn't need backport since it's covered here #3590

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested a review from a team as a code owner March 22, 2024 09:14
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Mar 22, 2024
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (c12080b) to head (aeb9002).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3593      +/-   ##
==========================================
- Coverage   86.14%   86.10%   -0.04%     
==========================================
  Files         699      699              
  Lines       21574    21574              
==========================================
- Hits        18585    18577       -8     
- Misses       2989     2997       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas merged commit 41e0a21 into master Mar 22, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-3100-prowler-security-hub-new-argument-sh-regions-to-set-to-what-regions-we-want-to-send-findings branch March 22, 2024 09:33
@sergargar sergargar added backport-v3 Pending to port to Prowler v3 branch and removed backport-v3 Pending to port to Prowler v3 branch labels Mar 26, 2024
pedrooot pushed a commit to pedrooot/prowler that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants