Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudformation): Update related URL #4134

Merged
merged 1 commit into from
May 30, 2024
Merged

chore(cloudformation): Update related URL #4134

merged 1 commit into from
May 30, 2024

Conversation

rieck-srlabs
Copy link
Contributor

Context

The "RelatedURL" for the cloudformation_stack_outputs_find_secrets check is not really helpful currently.

Description

Replaces the "RelatedURL" to point to AWS documentation describing CloudFormation outputs. The AWS documentation contains a warning stating that no secrets should be output.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rieck-srlabs rieck-srlabs requested review from a team May 30, 2024 09:11
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (52955f9) to head (b10a209).
Report is 430 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4134   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files         815      815           
  Lines       25468    25468           
=======================================
+ Hits        22071    22073    +2     
+ Misses       3397     3395    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great improvement! Thanks 🙌

@jfagoagas jfagoagas self-assigned this May 30, 2024
@sergargar sergargar merged commit 862bc8c into prowler-cloud:master May 30, 2024
10 of 11 checks passed
@rieck-srlabs rieck-srlabs deleted the bugfix/update-cloudformation-secrets-related-url branch June 6, 2024 09:06
sansns pushed a commit to sansns/prowler that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants