Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes unimplemented vNEXT doc. #40

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Deletes unimplemented vNEXT doc. #40

merged 1 commit into from
Jun 11, 2023

Conversation

mathetake
Copy link
Contributor

As a part of the project overhaul following the discussion in #38 (comment),
this commit deletes the never-implemented vNEXT ABI documentation
which has caused confusion to users and those willing to contribute.

The latest "implemented" specification version is v0.2.1, and the proper
documentation of v0.2.1 will be added to this repository as a follow-up PR.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
Copy link
Contributor Author

cc @mpwarres @martijneken @vikaschoudhary16 @jcchavezs

@jcchavezs
Copy link

Good to see some movement here!

@mpwarres mpwarres requested a review from PiotrSikora June 8, 2023 03:19
Copy link

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like to get @PiotrSikora 's ok on this as well.

@jcchavezs
Copy link

Ping @PiotrSikora

@mathetake
Copy link
Contributor Author

I believe the agreement is already made between @PiotrSikora and @mpwarres as-in #38 (comment), so I will go ahead and merge this. Thanks!

@mathetake mathetake merged commit 86719f5 into master Jun 11, 2023
2 checks passed
@mathetake mathetake deleted the removev1 branch June 11, 2023 21:56
@PiotrSikora
Copy link
Member

This is wrong and shouldn't have been merged.

I believe the agreement is already made between @PiotrSikora and @mpwarres as-in #38 (comment), so I will go ahead and merge this. Thanks!

@mpwarres clearly asked for my approval on this PR in #40 (review), so I don't understand why you chose to "believe" otherwise.

@codefromthecrypt
Copy link

not sure @mathetake replied to the correct issue on vNEXT or not.

I routinely point people to the issue that says it is broken. No one is looking to cause any problems, but we do want to avoid pain. Not two weeks ago, Takeshi and I had to privately explain why this document is confusing to an employee at a company we don't work at (redacted to protect the innocent)

Screenshot 2023-06-13 at 07 57 24

I'm not trying to convince you that deleting is the right answer, but it certainly wasn't motivated for any reason except to stop the constant damage to our time.

All this said, usually when I'm in an OSS project and someone with access merged something I don't agree with.. If I feel strongly, I'll revert it. I think if you want to revert it, even if that position is unpopular, others would accept it.

So, TL;DR; is my unsolicited 2p as a consumer not a committer, is revert if you feel this was wrong!

@PiotrSikora
Copy link
Member

I routinely point people to the issue that says it is broken. No one is looking to cause any problems, but we do want to avoid pain. Not two weeks ago, Takeshi and I had to privately explain why this document is confusing to an employee at a company we don't work at (redacted to protect the innocent)

Screenshot 2023-06-13 at 07 57 24 I'm not trying to convince you that deleting is the right answer, but it certainly wasn't motivated for any reason except to stop the constant damage to our time.

It says vNEXT right there in the link... but why are they looking at the ABI spec in the first place? I feel like there is some context missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants