-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deletes unimplemented vNEXT doc. #40
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Good to see some movement here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would like to get @PiotrSikora 's ok on this as well.
Ping @PiotrSikora |
I believe the agreement is already made between @PiotrSikora and @mpwarres as-in #38 (comment), so I will go ahead and merge this. Thanks! |
This is wrong and shouldn't have been merged.
@mpwarres clearly asked for my approval on this PR in #40 (review), so I don't understand why you chose to "believe" otherwise. |
not sure @mathetake replied to the correct issue on vNEXT or not. I routinely point people to the issue that says it is broken. No one is looking to cause any problems, but we do want to avoid pain. Not two weeks ago, Takeshi and I had to privately explain why this document is confusing to an employee at a company we don't work at (redacted to protect the innocent) ![]() I'm not trying to convince you that deleting is the right answer, but it certainly wasn't motivated for any reason except to stop the constant damage to our time. All this said, usually when I'm in an OSS project and someone with access merged something I don't agree with.. If I feel strongly, I'll revert it. I think if you want to revert it, even if that position is unpopular, others would accept it. So, TL;DR; is my unsolicited 2p as a consumer not a committer, is revert if you feel this was wrong! |
It says |
As a part of the project overhaul following the discussion in #38 (comment),
this commit deletes the never-implemented vNEXT ABI documentation
which has caused confusion to users and those willing to contribute.
The latest "implemented" specification version is
v0.2.1
, and the properdocumentation of v0.2.1 will be added to this repository as a follow-up PR.