Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text corrections on non-default textclasses fail #173

Closed
proycon opened this issue Apr 6, 2021 · 3 comments
Closed

Text corrections on non-default textclasses fail #173

proycon opened this issue Apr 6, 2021 · 3 comments
Assignees

Comments

@proycon
Copy link
Owner

proycon commented Apr 6, 2021

Text corrections on non-default textclasses fails because they introduce a new element (new text content), which subsequently does not inherit the right non-default text class but gets assigned the default one (current).

(This applies to joins, split and insertions, as well as individual tokens)

Discovered while debugging #170

@proycon proycon added the bug label Apr 6, 2021
@proycon proycon self-assigned this Apr 6, 2021
proycon added a commit to proycon/foliapy that referenced this issue Apr 6, 2021
proycon added a commit that referenced this issue Apr 7, 2021
proycon added a commit to proycon/foliapy that referenced this issue Apr 7, 2021
…). Allows setting textclass from a higher level and needed to solve proycon/flat#173
@proycon
Copy link
Owner Author

proycon commented Apr 7, 2021

This seems fixed in my latest development tests now.

@proycon proycon added ready and removed in progress labels Apr 7, 2021
@proycon proycon added in progress and removed ready labels Jul 1, 2021
@proycon
Copy link
Owner Author

proycon commented Jul 1, 2021

This now fails again, probably the fix I implemented for this issue leads to related problems elsewhere.
Correcting a text in the OCR textclass yields the following:

Editor submission failed: FoLiA Document Server error: FoLiA error in proycon/FA-b1_3_1_mwtext_vorbemerk_pp61_67_001: [ValueError] Textclass is not supported for TextContent

Query was: PROCESSOR name "proycon" type manual IN PROCESSOR name "FLAT" version "1.0" host "127.0.0.1:8000" src "http://127.0.0.1:8000/" IN PROCESSOR name "foliadocserve" version "0.7.5" host "mhysa.anaproy.nl" folia_version "2.5.0" src "https://github.com/proycon/foliadocserve" EDIT t OF https://raw.githubusercontent.com/proycon/folia/master/setdefinitions/text.foliaset.ttl WITH text "preussischen" textclass "OCR" datetime now confidence NONE (AS CORRECTION OF adhoc WITH class "test" datetime now confidence NONE) FOR ID FA-b1_3_1_mwtext_vorbemerk_pp61_67_001.text.div1.p4.s.2.w.9 FORMAT flat RETURN target

The same was also reported by @pirolen in #170 :

Editor submission failed: FoLiA Document Server error: FoLiA error in pirolen/FA-mittelalt_bibkat_sample_001: [ValueError] Textclass is not supported for TextContent

Query was: PROCESSOR name "pirolen" type manual IN PROCESSOR name "FLAT" version "1.0" host "138.246.225.16:8000" src "http://138.246.225.16:8000/" IN PROCESSOR name "foliadocserve" version "0.7.6" host "badwver-itservice2.srv.mwn.de" folia_version "2.5.0" src "https://github.com/proycon/foliadocserve" EDIT t OF https://raw.githubusercontent.com/proycon/folia/master/setdefinitions/text.foliaset.ttl WITH text "Summ" textclass "ocr" datetime now confidence NONE (AS CORRECTION OF https://raw.githubusercontent.com/pirolen/folia-resources/main/bibkat_ocr_corrections.foliaset.xml WITH class "other" datetime now confidence NONE) FOR ID FA-mittelalt_bibkat_sample_001.text.div.1.entry.1.term.1.s.1.w.1 FORMAT flat RETURN target

proycon added a commit to proycon/foliapy that referenced this issue Jul 1, 2021
… this), then textclass is interpreted as settextclass. (proycon/flat#173)
@proycon
Copy link
Owner Author

proycon commented Jul 1, 2021

Ok, this seems to fix it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant