Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pod install issue & listener conflict with document picker library #36

Closed
wants to merge 3 commits into from

Conversation

rinku-k
Copy link

@rinku-k rinku-k commented Apr 22, 2019

The pull request contains below fix -

  1. Pod demo swift added - helps users to run 'pod install' inside the library directly
    iOS Error: Cant find Pods.xcodeproject and can't able to pod install too #23

  2. Conflict with listener
    File-selector plugin is listening to document-picker file selection and throwing error causing app crash in some mobiles.

@rinku-k rinku-k changed the title Pod install issue & listner conflict with document picker library fix: Pod install issue & listener conflict with document picker library Apr 22, 2019
@prscX
Copy link
Owner

prscX commented Apr 23, 2019

Thanks @Rinkuk1993 for the Effort and PR.

  • w.r.t first point: the fix is for pod installation? Could you please share the exception which you were getting.

  • second point: fix w.r.t conflict with listener looks good.

Thanks
</ Pranav >

@rinku-k
Copy link
Author

rinku-k commented Apr 23, 2019

For the first point -
You can check this thread #23
#28

Normally people are not able to do pod install inside the library due to unavailability of swift file.
They have to manually create one from Xcode(normally people don't know how to do it).
For reference - check my comment on the issue thread #23

This fix will simply remove unwanted confusion.

Thanks

@rinku-k
Copy link
Author

rinku-k commented May 6, 2019

Is there an issue merging the changes? I am not sure about the status of this PR since there is no response

@crutchcorn
Copy link

I get the following error for this PR for iOS usage:

[!] The `RNFileSelector` pod failed to validate due to 1 error:
    - ERROR | attributes: Missing required attribute `homepage`.
    - WARN  | source: The version should be included in the Git tag.
    - WARN  | description: The description is equal to the summary.

@crutchcorn
Copy link

crutchcorn commented May 9, 2020

All it took to solve this issue was to change the podspec file:

  s.homepage     = "https://github.com/prscX/react-native-file-selector"

Then the iOS issue was resolved

@rinku-k
Copy link
Author

rinku-k commented Jul 21, 2020

Conflict with listener
File-selector plugin is listening to document-picker file selection and throwing error causing app crash in some mobiles.

I see that someone has already added PR for the above fix due to my inactivity. Since the code is same, I have removed my code.

Pod demo swift added - helps users to run 'pod install' inside the library directly
#23

If issue #23 is also fixed in another PR, let's close or discard this one.

@rinku-k rinku-k closed this Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants