Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for groups endpoint #131

Merged
merged 10 commits into from
Mar 12, 2021
Merged

Add support for groups endpoint #131

merged 10 commits into from
Mar 12, 2021

Conversation

dchess
Copy link
Contributor

@dchess dchess commented Aug 27, 2020

Fixes #132
This PR includes a new component for the groups endpoint and and group membership. Needed during new user creation if automation for group permissions is desired.

@dchess dchess mentioned this pull request Jan 28, 2021
@prschmid prschmid added this to the 1.1.6 milestone Feb 3, 2021
@prschmid
Copy link
Owner

@dchess Thanks for this PR! Looks like there is a conflict due to some formatting updates that were made when upgrading black to the latest version. Can I trouble you to pull the most recent develop and address the issues? Thank you!

@dchess
Copy link
Contributor Author

dchess commented Feb 17, 2021

@prschmid Take another look. I think that latest commit fixed the issue.

@prschmid prschmid self-requested a review February 17, 2021 17:12
@prschmid
Copy link
Owner

Much appreciated! I'll get to this in the next couple of days so that we can get it merged in.

Copy link
Owner

@prschmid prschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for all your efforts!

@prschmid prschmid merged commit 7b57dbb into prschmid:develop Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Groups & Group Membership
2 participants