Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Copy values in Profile comparaison dialog #5384

Closed
JulienThomas49 opened this issue Dec 6, 2020 · 8 comments
Closed

[Feature Request] Copy values in Profile comparaison dialog #5384

JulienThomas49 opened this issue Dec 6, 2020 · 8 comments

Comments

@JulienThomas49
Copy link

Version

2.3.0 Beta 2

Operating system type + version

Operating System : Windows
System Architecture : 64 bit
Windows Version : Windows 10 (build 19041)

3D printer brand / version + firmware version

Model : Ender 3 V1
Firmware version : 2.0.7.2

Feature request description

Add a comparison window which allows :

  • Easy comparison between two profiles (even with an external profile from hard disk)
  • Easy transfer values from one profile to another
  • any other usefull comparison tools.
@ShanDestromp
Copy link

To add to Juliens request (or provide my 'yes please' reasoning I guess), allow us to compare our profiles to the system profiles (particularly when the system profiles update). Like many I have a series of modified system profiles saved because that's really the only way we can have persistent changes to the built in profiles. Often those 'changes' are minor (eg I don't like the default infill pattern, or maybe I have fewer / more top & bottom layers but nothing else changed from default).

Whenever the system profiles are updated, the only (easy) way to compare is to save a new copy of the system profile and load both it and my version into a text editor and run a diff on them to see if there's anything worth changing, and then repeating this process for every single profile I've modified.

Obviously the mantra of 'if it's not broke don't fix it' applies to profiles, but then I (potentially) lose out on new features (ex infill anchors) and overall refinements. The current / new window that pops up when changing profiles is a good step in this direction but (AFAICT) only activates when you have unsaved changes in your profile, and only shows those unsaved changes.

My specific proposal:

Allow this dialog to be manually called with any two profiles and compare / transfer all differences between them.

@Kachidoki2807
Copy link

My two cents, IdeaMaker already propose a limited version (view only) of this comparison tool. It is a useful feature to instantly get the differences between updated profiles, but even more between different profiles, ie: between quality and speed profiles, or even between profiles from different printers.

The current inheritance system already help for that, thanks to the lock/unlock icon, but it does means the observed profile must inherit from a reference profile. It is a very limited but already powerful feature.

I am writing a vendor profile for an i3 based IDEX printer with a dozen of profiles, which inherit for the most part from the mk3s settings as the architecture and extruders are very similar. But now I have no way to easily compare my settings into PrusaSlicer, nor at the building of the profile since the .ini files are completely different. I have to export them one by one afterward to have a side-by-side comparable file.

The proposal of @ShanDestromp is a easy first step into this direction, and can even be enough to cover the most of use cases.

@LightningShark25
Copy link

+1
I can see the merits of the inheritance feature HOWEVER, I don't necessarily need inheritance. I'm likely to stuff things up by making it this complicated. I can see myself accidentally updating a setting in one profile, forgetting the inheritance, then not realising its changed in another profile.

@rtyr
Copy link
Collaborator

rtyr commented Feb 25, 2021

Same as #1566.

@mroek
Copy link

mroek commented Oct 25, 2021

So the profile comparison is actually great, but it is missing one important feature that is already mentioned in this feature request, and that is to be able to copy values from one profile to another while in the preset comparison view.

It would have been great to just be able to right-click on a setting, and from a popup choose "copy left" of "copy right". Are there any plans to introduce this?

@bubnikv
Copy link
Collaborator

bubnikv commented Oct 25, 2021 via email

@bubnikv bubnikv changed the title [Feature Request] Profile comparaison [Feature Request] Copy values in Profile comparaison dialog Dec 21, 2021
@Ic33s
Copy link

Ic33s commented Aug 14, 2022

As my request is closed. I want to add here, that at least for some settings (e.g. gcode for start and end) it would make sense to be able to freely edit them in the compare/merge view than, instead of only "copy left" and "copy right".

@kubispe1
Copy link
Collaborator

Easy comparison between two profiles (even with an external profile from hard disk)
Easy transfer values from one profile to another
any other usefull comparison tools.

This FR will be implemented with upcoming release 2.6.0. It is build into Compare Presets
Thanks

mmalecki pushed a commit to mmalecki/PrusaSlicer that referenced this issue Feb 1, 2023
Related to [Feature Request] prusa3d#5384 - Copy values in Profile comparaison dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants