New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide very minimum accessibility of PrusaSlicer #11651
base: master
Are you sure you want to change the base?
Conversation
Thanks a lot. Myself and @YuSanka have reviewed your PR. I must say that it is not nearly as convoluted as I was expecting and the amount of changes in the original code is quite small. A PR of this sort can definitely be merged after proper testing. Let us know when you consider it ready.
This would be nice, we are little nervous about how the zero-sized wxStaticTexts will work, but maybe it is just our general tendency not to trust wxWidgets. Out of curiosity, how well are screen readers in general supported on Linux and macOS? |
Thanks for interest. As for accessibility, Windows and Mac are pretty good here. For Windows we have extremely popular open-source screenreader NVDA and built-in Mac screenreader - VoiceOver - is also very good. On Linux we have ORCA, but it is far more limited than previous ones - what also can be generaly considered for GUIs on Linux, unfortunately. |
By the way, would there be any chance of considering replacing checkboxes with wxCheckbox class? It would be far, far more accessible on all platforms, current workaround is rather ugly. :) |
Okay, I see the same with Comboboxes. I can obviously find some ugly workaround. That will not be compliant with accessibility standards and will have many problems, but will work. |
@dawidpieper : This is not related to PrusaSlicer, even though I also have a Mk 3: I'm currently working on making wxGrid accessible. For this I would need testers and feedback. Would you mind looking at wxGlade/wxGlade#539 ? |
Partialy fixes #7595
This Pull Request is a starting point for making PrusaSlicer minimally accessible to blind people using screen readers.
There is no denying that it is actually a workaround. The idea in which the GUI was created is very far from the WX accessibility guidelines, and therefore the only options are to create a number of workarounds or rewrite a significant part of the code, which, as I was given to understand, is not being considered.
What does work
wxBitmapToggleButton`` does not support proper accessibility events, I would be greatly obliged to consider replacing its implementation with
wxCheckbox``.What does not work
Status
In my opinion, PrusaSlicer after implementing this PR has minimal accessibility, it can be used, albeit with limitations, by blind people using screen readers.
I would ask you to let me know if this PR has a chance of being merged, if so, I am willing to continue the work.