Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I've changed the Arrange function so that it makes sure that any skirt or brim added also fits the bed. No longer does one press the arrange button and then after one slices, the skirt/brim is outside the bed!
I've contained the libnest2d changes so that they are backwards compatible with earlier versions, to make it easier to merge with upstream.
I believe these changes fixes #3477 and #3072
I wasn't aware of #7653 until a couple of minutes ago. The major difference is that these changes I made are capable of handling individual brim settings, per object. I also found out that thread safety issue (but on my own, why didn't I read this earlier!!) and implemented the flow calculations directly from the configuration, much like bubnikv suggested here
Best,
David