Incorporate GeneratePryMan into pry. (continued from 785) #791
Conversation
Pry commands were listed using Pry version 0.9.10 on Ruby 1.9.3
Renamed the method copy_to_man_dir to move_to_man_dir. And changed the Rakefile to call by new name. This clears out 3 additional files per run.
Also exclude tests from running in jruby since ronn has a dependency on rdiscount (a c-extension).
test strings. Errors were caused by a header ronn puts which inserts the month and year. Simple solution was to gsub a dummy string in the tests that sets the month and year to expectd values.
|
Hey... did we have any reason not to merge this? |
|
It's a bit outdated now. |
ghost
assigned
|
It's vastly outdated now :D I'm still feeling sort of bad about not merging and resolving it in time. A proper, concise man page would be a nice addition to Pry. |
|
@kyrylo There is already a man page that is sufficient I think. This was mostly to keep the man page up to date as Pry features changed. |
|
@rondale-sc, I remember we had one, however... Do you have will or time to help fixing it? I think it should be succinct, just like our wiki page. |
|
@kyrylo The current man page is meant to be used with gem-man https://github.com/defunkt/gem-man I'm sure there is an alternative, a way to make it work with the default man command I'm just not sure how. I think it would involve some intrusive path manipulation. Not sure though, maybe @rking can weigh in. As far as writing up a succinct man page I'm totally on board / have some time just a matter of figuring out the best approach to getting it up and running. :) |
|
It looks like Rubygems isn't going to support the "classic" man pages. rubygems/rubygems#74 |
|
Closed, because we decided to remove the page altogether. #1019 |
See pull request history #785
The failing tests were caused by a date being set in the generated output that was hard set in the fixture.
Since generate_pry_man.rb writes the html/roff/ronn files to the
man/generate_pry_man/templates/dir and then moves them to the appropriate folder I adjusted the gitignore to prevent them from being tracked.Also wrapped the entire spec file inside a conditional that prevents it from being run in jruby without causing the tests to prematurely exit (per @kyrylo's reccomendation)