Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): lazy load modals #631

Merged
merged 2 commits into from
May 11, 2019
Merged

feat(ui): lazy load modals #631

merged 2 commits into from
May 11, 2019

Conversation

prymitive
Copy link
Owner

This uses React code splitting to only load modal content components if they are used - all modal components will be loaded the first time user open a modal, rather than on initial page load

@prymitive
Copy link
Owner Author

Need to wait for support in enzyme

This uses React code splitting to only load modal content components if they are used - all modal components will be loaded the first time user open a modal, rather than on initial page load
It's defined on Tooltip instead of the wrapper and it's not needed
@prymitive prymitive merged commit 019da86 into master May 11, 2019
@prymitive prymitive deleted the code-splitting branch May 11, 2019 18:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant