bugfix#30 #31
Merged
bugfix#30 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns the About dialog twice (the cache was returning the cached menuCmdID value, rather than running that action); TODO = verify it works with MIME Tools > URL Decode, and create a better test suite
…ite up a test that will verify one or more commands, predicated on the existence of the appropriate submenus.
==
This is a mixed file
https://example/%20%61%62%63
here is "%3d"
https://example/%20%61%62%63
print "\n" x 80;
for(1..2) {
editor->selectAll();
notepad->runPluginCommand('MIME Tools', 'URL Decode');
#print STDERR editor->getText();
sleep(5);
editor->undo();
#print STDERR editor->getText();
sleep(5);
}
editor->clearSelections();
==
…e test suite; will be doing a skip-based logic for the plugins
…y doing 2x each, it verifies cache; by verifying Converter>About, it verifies array argument; to avoid false-failure if someone has deleted/not-installed Converter plugin (which ships by default), it sets those tests as TODO; manually checked that -noPlugin still gives the Plugins menu; if for some reason it cannot find a plugins menu, it will skip the remaining tests. With all that together, strange configurations shouldn't give false-fail, but on reasonable systems, it will properly check; need to commit for more systems to verify with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runPluginsCommand() = fixed command cache feature and improved test (fixed #30)