Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix#30 #31

Merged
merged 5 commits into from
Apr 4, 2020
Merged

bugfix#30 #31

merged 5 commits into from
Apr 4, 2020

Commits on Apr 2, 2020

  1. notepad->runPluginCommand(Converter, About) for 1..2; now properly ru…

    …ns the About dialog twice (the cache was returning the cached menuCmdID value, rather than running that action); TODO = verify it works with MIME Tools > URL Decode, and create a better test suite
    pryrt committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    2678993 View commit details
    Browse the repository at this point in the history
  2. According to the test script below, it's working... I just need to wr…

    …ite up a test that will verify one or more commands, predicated on the existence of the appropriate submenus.
    
    ==
    This is a mixed file
    https://example/%20%61%62%63
    here is "%3d"
    https://example/%20%61%62%63
    
    print "\n" x 80;
    for(1..2) {
        editor->selectAll();
        notepad->runPluginCommand('MIME Tools', 'URL Decode');
        #print STDERR editor->getText();
        sleep(5);
        editor->undo();
        #print STDERR editor->getText();
        sleep(5);
    }
    editor->clearSelections();
    ==
    pryrt committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    c1e262f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. move the menuCommand, runMenuCommand, and runPluginCommand to separat…

    …e test suite; will be doing a skip-based logic for the plugins
    pryrt committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    fe32500 View commit details
    Browse the repository at this point in the history
  2. update npp-menucmd.t to run PluginsAdmin 2x and Converter>About 2x; b…

    …y doing 2x each, it verifies cache; by verifying Converter>About, it verifies array argument; to avoid false-failure if someone has deleted/not-installed Converter plugin (which ships by default), it sets those tests as TODO; manually checked that -noPlugin still gives the Plugins menu; if for some reason it cannot find a plugins menu, it will skip the remaining tests. With all that together, strange configurations shouldn't give false-fail, but on reasonable systems, it will properly check; need to commit for more systems to verify with
    pryrt committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    b69903a View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2020

  1. Configuration menu
    Copy the full SHA
    d23f220 View commit details
    Browse the repository at this point in the history