Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator aggregation request #111

Merged
merged 3 commits into from
Feb 26, 2020
Merged

Validator aggregation request #111

merged 3 commits into from
Feb 26, 2020

Conversation

mpetrunic
Copy link
Contributor

  • add missing api for validator to submit aggregation request

Hope I've done this properly, I can see added api in swaggerUI so I hope it works.

@prestonvanloon
Copy link
Member

Looks like this method was leftover from a recent refactoring / migration to ethereumapis in Prysm.

Working on this now and I will follow up shortly.

terencechain
terencechain previously approved these changes Feb 26, 2020
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for catching that it's missing 🙏

eth/v1alpha1/validator.proto Outdated Show resolved Hide resolved
@prestonvanloon
Copy link
Member

Do not merge yet, I'll add some comments to the proto messages.

Co-Authored-By: terence tsao <terence@prysmaticlabs.com>
@prestonvanloon prestonvanloon merged commit fca4d6f into prysmaticlabs:master Feb 26, 2020
@mpetrunic mpetrunic deleted the mpetrunic/validator-aggregate branch February 27, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants