Clean up unused / deprecated protobuf definitions #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Feb 26, 2020
|
Looks like cluster PK manager is still holding onto some of these definitions. Working on that now. |
0xKiwi
approved these changes
Feb 26, 2020
terencechain
approved these changes
Feb 26, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Remove unused services, mark everything as deprecated, regen pb.go * remove some code from cluster pk manager, gazelle * goimports * remove mocks * Merge branch 'master' into remove-deprecated-proto-defs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of prysmaticlabs/ethereumapis#111