-
Notifications
You must be signed in to change notification settings - Fork 985
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add validator blob signing (#12730)
- Loading branch information
1 parent
f7c7f77
commit fe1b4c2
Showing
6 changed files
with
187 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
package client | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/pkg/errors" | ||
"github.com/prysmaticlabs/prysm/v4/beacon-chain/core/signing" | ||
fieldparams "github.com/prysmaticlabs/prysm/v4/config/fieldparams" | ||
"github.com/prysmaticlabs/prysm/v4/config/params" | ||
ethpb "github.com/prysmaticlabs/prysm/v4/proto/prysm/v1alpha1" | ||
validatorpb "github.com/prysmaticlabs/prysm/v4/proto/prysm/v1alpha1/validator-client" | ||
"github.com/prysmaticlabs/prysm/v4/time/slots" | ||
) | ||
|
||
func (v *validator) signBlob(ctx context.Context, blob *ethpb.BlobSidecar, pubKey [fieldparams.BLSPubkeyLength]byte) ([]byte, error) { | ||
epoch := slots.ToEpoch(blob.Slot) | ||
domain, err := v.domainData(ctx, epoch, params.BeaconConfig().DomainBlobSidecar[:]) | ||
if err != nil { | ||
return nil, errors.Wrap(err, domainDataErr) | ||
} | ||
if domain == nil { | ||
return nil, errors.New(domainDataErr) | ||
} | ||
sr, err := signing.ComputeSigningRoot(blob, domain.SignatureDomain) | ||
if err != nil { | ||
return nil, errors.Wrap(err, signingRootErr) | ||
} | ||
sig, err := v.keyManager.Sign(ctx, &validatorpb.SignRequest{ | ||
PublicKey: pubKey[:], | ||
SigningRoot: sr[:], | ||
SignatureDomain: domain.SignatureDomain, | ||
Object: &validatorpb.SignRequest_Blob{Blob: blob}, | ||
SigningSlot: blob.Slot, | ||
}) | ||
if err != nil { | ||
return nil, errors.Wrap(err, "could not sign block proposal") | ||
} | ||
return sig.Marshal(), nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
package client | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
"github.com/golang/mock/gomock" | ||
"github.com/prysmaticlabs/prysm/v4/beacon-chain/core/signing" | ||
fieldparams "github.com/prysmaticlabs/prysm/v4/config/fieldparams" | ||
"github.com/prysmaticlabs/prysm/v4/config/params" | ||
"github.com/prysmaticlabs/prysm/v4/crypto/bls" | ||
"github.com/prysmaticlabs/prysm/v4/encoding/bytesutil" | ||
ethpb "github.com/prysmaticlabs/prysm/v4/proto/prysm/v1alpha1" | ||
"github.com/prysmaticlabs/prysm/v4/testing/require" | ||
) | ||
|
||
func Test_validator_signBlob(t *testing.T) { | ||
v, m, vk, finish := setup(t) | ||
defer finish() | ||
|
||
m.validatorClient.EXPECT(). | ||
DomainData(gomock.Any(), // ctx | ||
ðpb.DomainRequest{ | ||
Domain: params.BeaconConfig().DomainBlobSidecar[:], | ||
}). // epoch | ||
Return(ðpb.DomainResponse{ | ||
SignatureDomain: bytesutil.PadTo([]byte("signatureDomain"), 32), | ||
}, nil) | ||
|
||
blob := ðpb.BlobSidecar{ | ||
BlockRoot: bytesutil.PadTo([]byte("blockRoot"), 32), | ||
Index: 1, | ||
Slot: 2, | ||
BlockParentRoot: bytesutil.PadTo([]byte("blockParentRoot"), 32), | ||
ProposerIndex: 3, | ||
Blob: bytesutil.PadTo([]byte("blob"), fieldparams.BlobLength), | ||
KzgCommitment: bytesutil.PadTo([]byte("kzgCommitment"), 48), | ||
KzgProof: bytesutil.PadTo([]byte("kzgPRoof"), 48), | ||
} | ||
ctx := context.Background() | ||
sig, err := v.signBlob(ctx, blob, [48]byte(vk.PublicKey().Marshal())) | ||
require.NoError(t, err) | ||
pb, err := bls.PublicKeyFromBytes(vk.PublicKey().Marshal()) | ||
require.NoError(t, err) | ||
signature, err := bls.SignatureFromBytes(sig) | ||
require.NoError(t, err) | ||
sr, err := signing.ComputeSigningRoot(blob, bytesutil.PadTo([]byte("signatureDomain"), 32)) | ||
require.NoError(t, err) | ||
|
||
require.Equal(t, true, signature.Verify(pb, sr[:])) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters