Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Case When ChainID != NetworkID When Signing Transactions #14

Closed
rauljordan opened this issue Jan 28, 2018 · 3 comments
Closed

Consider Case When ChainID != NetworkID When Signing Transactions #14

rauljordan opened this issue Jan 28, 2018 · 3 comments
Labels
Enhancement New feature or request
Milestone
Diamond

Comments

@rauljordan
Copy link
Contributor

On Ethereum Classic, ChainID != NetworkID and the following code would fail when signing the initial contract creation transaction in vmc.go:

return c.keystore.SignTx(accounts[0], tx, networkID /* chainID */)

We currently fetch networkID via the ethclient's NetworkID method, but we should consider situations in which this could break. Keeping it as an open issue for now.
@rauljordan rauljordan added the Enhancement New feature or request label Jan 28, 2018
@rauljordan rauljordan added this to the Ruby milestone Feb 25, 2018
@prestonvanloon prestonvanloon modified the milestones: Ruby, Diamond Apr 23, 2018
@prestonvanloon
Copy link
Member

Moving to full production release (diamond)

@rauljordan rauljordan changed the title Consider case when ChainID != NetworkID when signing transactions Consider Case When ChainID != NetworkID When Signing Transactions Jul 4, 2018
@prestonvanloon
Copy link
Member

@rauljordan can you comment why this was closed?

@rauljordan
Copy link
Contributor Author

This should be irrelevant now that we have the beacon chain. There will be no need to have write access to a mainchain node, and no need to consider this case as we will not be signing mainchain transactions.

mdehoog pushed a commit to mdehoog/prysm that referenced this issue Oct 4, 2022
@dgcoffman
Modify hashToBLSField to do hash(ssz_serialize(x)) (prysmaticlabs#14)
8600fb5
draganm pushed a commit to manifoldfinance/prysm that referenced this issue Mar 13, 2023
@avalonche
Capella fixes (prysmaticlabs#14)
046224f
@wzl521 wzl521 mentioned this issue Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
Diamond
Development

No branches or pull requests
2 participants
@rauljordan @prestonvanloon