Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster BLS publickey.Copy #4770

Merged
merged 10 commits into from Feb 6, 2020
Merged

Faster BLS publickey.Copy #4770

merged 10 commits into from Feb 6, 2020

Conversation

prestonvanloon
Copy link
Member

Builds on #4769

Before

Screenshot from 2020-02-05 20-53-12

After

Screenshot from 2020-02-05 20-53-20

Marking work in progress until its been run at runtime long enough.

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@550f5c4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4770   +/-   ##
=========================================
  Coverage          ?   55.62%           
=========================================
  Files             ?      249           
  Lines             ?    19228           
  Branches          ?        0           
=========================================
  Hits              ?    10695           
  Misses            ?     6966           
  Partials          ?     1567

@prestonvanloon prestonvanloon added Ready For Review A pull request ready for code review and removed In Progress labels Feb 6, 2020
@prestonvanloon prestonvanloon marked this pull request as ready for review February 6, 2020 17:15
@prestonvanloon prestonvanloon changed the title WIP: Faster BLS publickey.Copy Faster BLS publickey.Copy Feb 6, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit c7fb28d into master Feb 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the bls-better-copy branch February 6, 2020 17:35
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Use balancesLength and randaoMixesLength to save copy on read
* use a cheaper copy for BLS publickey.Copy()
* Merge branch 'master' into bls-better-copy
* Merge refs/heads/master into bls-better-copy
* Merge refs/heads/master into bls-better-copy
* Merge refs/heads/master into bls-better-copy
* Merge refs/heads/master into bls-better-copy
* Merge branch 'master' of github.com:prysmaticlabs/prysm into bls-better-copy
* quick test
* Merge refs/heads/master into bls-better-copy
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Use balancesLength and randaoMixesLength to save copy on read
* use a cheaper copy for BLS publickey.Copy()
* Merge branch 'master' into bls-better-copy
* Merge refs/heads/master into bls-better-copy
* Merge refs/heads/master into bls-better-copy
* Merge refs/heads/master into bls-better-copy
* Merge refs/heads/master into bls-better-copy
* Merge branch 'master' of github.com:prysmaticlabs/prysm into bls-better-copy
* quick test
* Merge refs/heads/master into bls-better-copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants