Discovery Fixes #5050
Merged
Discovery Fixes #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nisdas
commented
Mar 9, 2020
nisdas
commented
- Read random nodes to find new nodes from our local table.
- Bump up polling period to 30 seconds to lookup new peers.
- Connect to discovery v5 bootnodes.
nisdas
added
Ready For Review
terencechain
reviewed
Mar 9, 2020
beacon-chain/p2p/service.go
Outdated
| @@ -30,7 +30,8 @@ import ( | |||
|
|
|||
| var _ = shared.Service(&Service{}) | |||
|
|
|||
| var pollingPeriod = 1 * time.Second | |||
| // check local table every 30 seconds for newly added peers. | |||
| var pollingPeriod = 30 * time.Second | |||
There was a problem hiding this comment.
is this formal enough to be defined in beacon's config.go?
There was a problem hiding this comment.
Not really, most of these params are only useful in the p2p package. This is just a baseline on how often to poll our local table for new peers. I think they are fine living here in this package.
Codecov Report
@@ Coverage Diff @@
## master #5050 +/- ##
=======================================
Coverage 44.62% 44.62%
=======================================
Files 214 214
Lines 16814 16814
=======================================
Hits 7504 7504
Misses 7992 7992
Partials 1318 1318 |
terencechain
reviewed
Mar 9, 2020
rauljordan
previously approved these changes
Mar 9, 2020
|
Tests fail @nisdas |
prestonvanloon
previously approved these changes
Mar 10, 2020
|
Discovery unit tests are failing |
prestonvanloon
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.