New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovery Fixes #5050
Discovery Fixes #5050
Conversation
nisdas
commented
Mar 9, 2020
- Read random nodes to find new nodes from our local table.
- Bump up polling period to 30 seconds to lookup new peers.
- Connect to discovery v5 bootnodes.
beacon-chain/p2p/service.go
Outdated
@@ -30,7 +30,8 @@ import ( | |||
|
|||
var _ = shared.Service(&Service{}) | |||
|
|||
var pollingPeriod = 1 * time.Second | |||
// check local table every 30 seconds for newly added peers. | |||
var pollingPeriod = 30 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this formal enough to be defined in beacon's config.go
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, most of these params are only useful in the p2p
package. This is just a baseline on how often to poll our local table for new peers. I think they are fine living here in this package.
Codecov Report
@@ Coverage Diff @@
## master #5050 +/- ##
=======================================
Coverage 44.62% 44.62%
=======================================
Files 214 214
Lines 16814 16814
=======================================
Hits 7504 7504
Misses 7992 7992
Partials 1318 1318 |
Tests fail @nisdas |
Discovery unit tests are failing |